Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 luet autobump for k3s is not working #1934

Open
mauromorales opened this issue Oct 20, 2023 · 4 comments · Fixed by Luet-lab/extensions#12
Open

🤖 luet autobump for k3s is not working #1934

mauromorales opened this issue Oct 20, 2023 · 4 comments · Fixed by Luet-lab/extensions#12
Labels
bug Something isn't working chore

Comments

@mauromorales
Copy link
Member

mauromorales commented Oct 20, 2023 •
edited
Loading

K3s is special in that it comes with these +k3s1 attached to the version. Unfortunately the collection does not expect and adds it later in the build script. The result is that when autobump tries to do the bump, we get versions like v1.28.2+k3s1+k3s1, which break the k3s installation script, see: kairos-io/packages#413

Another issue is that autobump brings also rc versions
@mauromorales mauromorales added bug Something isn't working chore labels Oct 20, 2023
@mauromorales mauromorales changed the title K3s upgrade is failing on CI 🤖 luet autobump for k3s is not working Oct 20, 2023
@jimmykarily jimmykarily added the triage Add this label to issues that should be triaged and prioretized in the next planning call label Oct 23, 2023
@jimmykarily
Copy link
Contributor

The autobumper: https://github.com/Luet-lab/extensions/blob/master/extensions/autobump-github/luet-autobump-github

@jimmykarily jimmykarily removed the triage Add this label to issues that should be triaged and prioretized in the next planning call label Oct 23, 2023
@mauromorales mauromorales self-assigned this Oct 23, 2023
mauromorales added a commit to mauromorales/extensions that referenced this issue Oct 24, 2023
@mauromorales
Add mechanism to run a sed script directly without using jq
393a530 
It also introduces the release_tag strategy in order to make testing easier

Fixes kairos-io/kairos#1934
@mauromorales
Copy link
Member Author

I'm not sure if the system always upgrades the smallest package in a collection. I need to investigate further

This was referenced Oct 24, 2023
Closed
Merged
@mauromorales
Copy link
Member Author

PR Luet-lab/extensions#12

mauromorales added a commit to kairos-io/packages that referenced this issue Oct 25, 2023
@mauromorales
Remove the +k3s1 part on k3s packages
db52068 
relates to kairos-io/kairos#1934

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@mauromorales mauromorales mentioned this issue Oct 25, 2023
Merged
mauromorales added a commit to kairos-io/packages that referenced this issue Oct 27, 2023
@mauromorales
Remove the +k3s1 part on k3s packages (#522)
b03604e 
* Remove the +k3s1 part on k3s packages

relates to kairos-io/kairos#1934

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>

* remove release to avoid bumping all packages

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>

---------

Signed-off-by: Mauro Morales <mauro.morales@spectrocloud.com>
@jimmykarily jimmykarily reopened this Oct 30, 2023
@mauromorales mauromorales removed their assignment Nov 13, 2023
@mauromorales
Copy link
Member Author

putting back since it's not high prio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working chore
Projects
🧙Issue tracking board
Status: No status
Milestone
No milestone
2 participants
@mauromorales @jimmykarily