Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release tag and sed script to autobump extension #12

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Add release tag and sed script to autobump extension #12

merged 4 commits into from
Oct 25, 2023

Conversation

mauromorales
Copy link
Contributor

Fixes kairos-io/kairos#1934

  • adds tests for the autobump functionality using golden files
  • extend autobump to use a specific release tag
  • extend autobump to use a specific sed script instead of multiple keys and replace, since this breaks with fancy scripts like \+k3s :p

@mauromorales
Make github autobump tests pass
546559d 
- lint improvement on script
- remove extra line in go version response
@mauromorales
Only create .bin dir if missing
4e44fdc
@mauromorales
Add golden files and validation
e78455b
@mauromorales
Add mechanism to run a sed script directly without using jq
393a530 
It also introduces the release_tag strategy in order to make testing easier

Fixes kairos-io/kairos#1934
@mauromorales
Copy link
Contributor Author

cc @mudler

@mauromorales mauromorales mentioned this pull request Oct 25, 2023
Open
@mudler mudler merged commit 43b26be into Luet-lab:master Oct 25, 2023
1 check failed
@mauromorales mauromorales deleted the 1934-luet-autobump-github-extension branch October 25, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudler mudler mudler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🤖 luet autobump for k3s is not working
2 participants
@mauromorales @mudler