Skip to content

add an error message if model doesn't support function calling #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EItanya merged 2 commits into from
Nov 25, 2025
Merged

add an error message if model doesn't support function calling #1114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef4ba0d
add an error message if model doesn't support function calling
peterj Nov 20, 2025
e6e3c67
lint errors
peterj Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion python/packages/kagent-adk/src/kagent/adk/_agent_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,23 @@ async def execute(
await self._handle_request(context, event_queue, runner, run_args)
except Exception as e:
logger.error("Error handling A2A request: %s", e, exc_info=True)

# Check if this is a LiteLLM JSON parsing error (common with Ollama models that don't support function calling)
error_message = str(e)
if (
"JSONDecodeError" in error_message
or "Unterminated string" in error_message
or "APIConnectionError" in error_message
):
# Check if it's related to function calling
if "function_call" in error_message.lower() or "json.loads" in error_message:
error_message = (
"The model does not support function calling properly. "
"This error typically occurs when using Ollama models with tools. "
"Please either:\n"
"1. Remove tools from the agent configuration, or\n"
"2. Use a model that supports function calling (e.g., OpenAI, Anthropic, or Gemini models)."
)
# Publish failure event
try:
await event_queue.enqueue_event(
Expand All @@ -156,7 +173,7 @@ async def execute(
message=Message(
message_id=str(uuid.uuid4()),
role=Role.agent,
parts=[Part(TextPart(text=str(e)))],
parts=[Part(TextPart(text=error_message))],
),
),
context_id=context.context_id,
Expand Down
Loading