add an error message if model doesn't support function calling #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds improved error messaging to help users understand when their model doesn't support function calling, addressing issue #1112. When certain error patterns are detected (JSONDecodeError, unterminated strings, or API connection errors), the system now provides a user-friendly message explaining the problem and suggesting solutions.
- Detects function calling compatibility errors through pattern matching in exception messages
- Replaces cryptic error messages with actionable guidance for users
- Maintains backward compatibility by only replacing messages when specific patterns are detected
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EItanya
previously approved these changes
Nov 24, 2025
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
peterj
force-pushed
the
peterj/funccallmsgh
branch
from
1d94364 to
e6e3c67
Compare
EItanya
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1112 , but it doesn't fix it since the fix is to use a model that supports function calling. However, we'll now show a message if the model doesn't support function calling.