Skip to content

fix: proto benchmark key collision and memory DBSIZE parsing #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kacy merged 1 commit into from
Feb 16, 2026
Merged

fix: proto benchmark key collision and memory DBSIZE parsing #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bench/bench-memory.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ measure_ember_type() {
local mem_after
mem_after=$(get_redis_memory "$port")
local keys
keys=$(redis-cli -p "$port" DBSIZE 2>/dev/null | awk '{print $2}' | tr -d '\r')
keys=$(redis-cli -p "$port" DBSIZE 2>/dev/null | awk '{print $NF}' | tr -d '\r')

local used=$((mem_after - mem_before))
local bytes_per_key=0
Expand Down Expand Up @@ -183,7 +183,7 @@ measure_redis_type() {
local mem_after
mem_after=$(get_redis_memory "$port")
local keys
keys=$(redis-cli -p "$port" DBSIZE 2>/dev/null | awk '{print $2}' | tr -d '\r')
keys=$(redis-cli -p "$port" DBSIZE 2>/dev/null | awk '{print $NF}' | tr -d '\r')

local used=$((mem_after - mem_before))
local bytes_per_key=0
Expand Down
12 changes: 6 additions & 6 deletions bench/bench-proto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def compute_stats(elapsed, latencies, count):
def bench_raw_set(r, keys, value, warmup=1000):
"""raw SET throughput (no validation)."""
for i in range(warmup):
r.set(f"warmup:{i}", value)
r.set(f"raw_warmup:{i}", value)

latencies = []
start = time.perf_counter()
Expand All @@ -117,7 +117,7 @@ def bench_raw_set(r, keys, value, warmup=1000):
def bench_raw_get(r, keys, warmup=1000):
"""raw GET throughput."""
for i in range(warmup):
r.get(f"warmup:{i}")
r.get(f"raw_warmup:{i}")

latencies = []
start = time.perf_counter()
Expand All @@ -132,7 +132,7 @@ def bench_raw_get(r, keys, warmup=1000):
def bench_proto_set(r, keys, value, type_name, warmup=1000):
"""PROTO.SET throughput (schema-validated)."""
for i in range(warmup):
r.execute_command("PROTO.SET", f"warmup:{i}", type_name, value)
r.execute_command("PROTO.SET", f"proto_warmup:{i}", type_name, value)

latencies = []
start = time.perf_counter()
Expand All @@ -147,7 +147,7 @@ def bench_proto_set(r, keys, value, type_name, warmup=1000):
def bench_proto_get(r, keys, warmup=1000):
"""PROTO.GET throughput."""
for i in range(warmup):
r.execute_command("PROTO.GET", f"warmup:{i}")
r.execute_command("PROTO.GET", f"proto_warmup:{i}")

latencies = []
start = time.perf_counter()
Expand All @@ -162,7 +162,7 @@ def bench_proto_get(r, keys, warmup=1000):
def bench_proto_getfield(r, keys, field, warmup=1000):
"""PROTO.GETFIELD throughput (single field read)."""
for i in range(warmup):
r.execute_command("PROTO.GETFIELD", f"warmup:{i}", field)
r.execute_command("PROTO.GETFIELD", f"proto_warmup:{i}", field)

latencies = []
start = time.perf_counter()
Expand All @@ -177,7 +177,7 @@ def bench_proto_getfield(r, keys, field, warmup=1000):
def bench_proto_setfield(r, keys, field, value, warmup=1000):
"""PROTO.SETFIELD throughput (single field update)."""
for i in range(warmup):
r.execute_command("PROTO.SETFIELD", f"warmup:{i}", field, value)
r.execute_command("PROTO.SETFIELD", f"proto_warmup:{i}", field, value)

latencies = []
start = time.perf_counter()
Expand Down