fix: proto benchmark key collision and memory DBSIZE parsing#157
Merged
Conversation
proto benchmark: warmup keys used the same prefix for both raw SET and
PROTO.SET, causing WRONGTYPE errors when raw GET hit proto-typed keys.
use distinct prefixes (raw_warmup: vs proto_warmup:) for each benchmark.
memory benchmark: ember returns DBSIZE as a bare number (e.g. "8605")
while redis returns "(integer) 8605". awk '{print $2}' only worked for
redis format, returning empty for ember — causing 0 bytes/key. switched
to awk '{print $NF}' which handles both formats.
kacy
added a commit
that referenced
this pull request
Feb 19, 2026
#157) proto benchmark: warmup keys used the same prefix for both raw SET and PROTO.SET, causing WRONGTYPE errors when raw GET hit proto-typed keys. use distinct prefixes (raw_warmup: vs proto_warmup:) for each benchmark. memory benchmark: ember returns DBSIZE as a bare number (e.g. "8605") while redis returns "(integer) 8605". awk '{print $2}' only worked for redis format, returning empty for ember — causing 0 bytes/key. switched to awk '{print $NF}' which handles both formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
fixes two benchmark bugs found during GCP testing:
bench-proto.py: warmup keys used the same
warmup:prefix for both raw SET and PROTO.SET operations. when raw GET later reads those keys, it hits proto-typed values and crashes with WRONGTYPE. fixed by using distinct prefixes (raw_warmup:for raw ops,proto_warmup:for proto ops).bench-memory.sh: ember's DBSIZE returns a bare number (
8605) while redis returns(integer) 8605. the script usedawk '{print $2}'which only matched the redis format, returning empty for ember — making all byte/key calculations divide by zero and report 0. switched toawk '{print $NF}'which handles both.what was tested
awk '{print $NF}'works for both ember and redis DBSIZE output formatsused_memoryafter data load