Restore k0s spec.api.sans updating that was removed in #772 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kke
force-pushed
the
bring-back-sans-manipulation
branch
from
681df27
to
76c3b60
Compare
kke
commented
Nov 4, 2024
kke
force-pushed
the
bring-back-sans-manipulation
branch
from
b6f98d4
to
1462a74
Compare
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
Signed-off-by: Kimmo Lehto <klehto@mirantis.com>
kke
force-pushed
the
bring-back-sans-manipulation
branch
from
1462a74
to
27b65e1
Compare
kke
changed the title
kke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #782
Closes k0sproject/k0s#5157 (skip v0.19.2 bump)
Brings back and improves the k0s config
spec.api.sansmanipulation that was removed in #772 commit fd0ba50 - turns out adding at least the controller's public address is required as k0s will not always get it fromiface.AllAddresses()(NAT, fqdn, etc). Also restored the adding of the addresses of all the other controllers.Now a single list of SANs is built globally just once and it should be identical between controllers. The list includes the addresses and possibly private addresses of all controllers.