Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/k0sproject/k0sctl from 0.19.0 to 0.19.2 in /hack/tool #5157

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 25, 2024

Bumps github.com/k0sproject/k0sctl from 0.19.0 to 0.19.2.

Release notes

Sourced from github.com/k0sproject/k0sctl's releases.

v0.19.2

What's Changed

Full Changelog: k0sproject/k0sctl@v0.19.1...v0.19.2

SHA256 Checksums

8892d497ff53a35e95255aa31fe3dd544a6c65304490c78baa999b4ed75f7e91 *k0sctl-linux-amd64
030545c43ef8bd320267677efd3a7e3a9f18d37f01960181b664a3f047b7e496 *k0sctl-linux-arm64
ce6ad5454a2787dafc43b0906aa9db351a1689df0bda5e3b3b0399d14d274b63 *k0sctl-linux-arm
bebeef270e11cd250772bc264b68a442d2ffc878c6b45cdcbc9ce3109c04d190 *k0sctl-win-amd64.exe
1fbb6fa2216d92c3ce6381067d3d3a01e864cc1f54b757149c2505e86c396d75 *k0sctl-darwin-amd64
a714b77c588d25f2f1cb97c7a7f03d333e9093e34bd4ce686e719fa8bb5417de *k0sctl-darwin-arm64

v0.19.1

What's Changed

Full Changelog: k0sproject/k0sctl@v0.19.0...v0.19.1

SHA256 Checksums

9b360ef47f1cac3669bd6ea44f1c8b2a5b6070c61085abf9c871df3267f44a39 *k0sctl-linux-amd64
d9aa1616d2c733b9af6cad5c99e4190eb15c41262608708d35a9320ad771422f *k0sctl-linux-arm64
2a803ee49306bbb2493d0581314145318c75801bd9240353869417cc8368a6a6 *k0sctl-linux-arm
f9db46f1ab2bf1c17a6436408960614ebd8f05b2aebdc676f8225c7eceb8f8a9 *k0sctl-win-amd64.exe
c0ac0f36342c14addeb6833c169c57cbbf8206a02d141bfd3260c6daa8e79cea *k0sctl-darwin-amd64
ec0007e79f699780a56d0634f7254ff3507add5143eedc7d1b7a941521ae05dd *k0sctl-darwin-arm64
Commits
  • 081dfeb Fix k0s CPLB config parsing interface conversion panic (#776)
  • 0646847 Use go1.23.2, update dependencies (#774)
  • 09cfd11 Extract etcd membership check into a separate phase (#770)
  • 4c6450d Merge pull request #772 from k0sproject/validate-connection-vrrp-ip
  • fd0ba50 Remove all SANs manipulation as k0s does it on its own
  • 3f9f91d Validate worker connectivity to cluster-internal addresses
  • 6b9054b Consider k0s onlyBindToAddress option when building API URLs
  • ec2a1f9 Fall back to CPLB virtual address in external API URL
  • b8a2fd0 Merge pull request #769 from k0sproject/modifiable-applyaction
  • 5bc7203 Make Apply action phase list modifiable before Run()
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from a team as code owners October 25, 2024 13:53
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 25, 2024
@twz123 twz123 disabled auto-merge October 25, 2024 18:41
@twz123
Copy link
Member

twz123 commented Oct 25, 2024

Need to check the OS tests first.

@twz123
Copy link
Member

twz123 commented Oct 28, 2024

@twz123
Copy link
Member

twz123 commented Oct 28, 2024

https://github.com/k0sproject/k0s/actions/runs/11555710396

Still not working:

time="2024-10-28T14:16:16Z" level=error msg="could not create sonobuoy client: couldn't get sonobuoy api helper: could not get api group resources: Get "https://23.22.141.30:6443/api?timeout=32s\": tls: failed to verify certificate: x509: certificate is valid for 127.0.0.1, 172.31.3.84, fe80::c52:27ff:fe02:1e19, 10.96.0.1, not 23.22.141.30"

@kke Mind to have a look?

Copy link
Contributor

This pull request has merge conflicts that need to be resolved.

@dependabot dependabot bot force-pushed the dependabot/go_modules/hack/tool/github.com/k0sproject/k0sctl-0.19.2 branch from 7bab297 to d8df62e Compare October 29, 2024 18:45
@twz123 twz123 disabled auto-merge October 30, 2024 08:06
Copy link
Member

@twz123 twz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumps [github.com/k0sproject/k0sctl](https://github.com/k0sproject/k0sctl) from 0.19.0 to 0.19.2.
- [Release notes](https://github.com/k0sproject/k0sctl/releases)
- [Commits](k0sproject/k0sctl@v0.19.0...v0.19.2)

---
updated-dependencies:
- dependency-name: github.com/k0sproject/k0sctl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/hack/tool/github.com/k0sproject/k0sctl-0.19.2 branch from d8df62e to 7f71323 Compare October 30, 2024 08:08
@twz123 twz123 disabled auto-merge October 30, 2024 10:08
@kke
Copy link
Contributor

kke commented Oct 31, 2024

All SANs manipulation was removed from k0sctl as k0s does it on its own.

Looks like some of them were not redundant.

@kke
Copy link
Contributor

kke commented Oct 31, 2024

It was made in k0sproject/k0sctl@fd0ba50

spec.api.externalAddress, the private address and 127.0.0.1 used to be added to sans.

@kke
Copy link
Contributor

kke commented Oct 31, 2024

k0s does this:

// Sans return the given SANS plus all local addresses and externalAddress if given
func (a *APISpec) Sans() []string {
	sans, _ := iface.AllAddresses()
	sans = append(sans, a.Address)
	sans = append(sans, a.SANs...)
	if a.ExternalAddress != "" {
		sans = append(sans, a.ExternalAddress)
	}

	return stringslice.Unique(sans)
}

@kke
Copy link
Contributor

kke commented Oct 31, 2024

Could it be that 23.22.x.x is not returned from iface.AllAddresses()?

	sans = append(sans, a.Address)

k0sctl sets this to the private address of the node or the public one if not set.

@kke
Copy link
Contributor

kke commented Oct 31, 2024

Should k0sctl maybe default spec.api.externalAddress to leader's public address if empty? 🤔

@kke
Copy link
Contributor

kke commented Nov 1, 2024

Adding the public address to SANs could make sense since it could be a NAT address not actually existing on the host.

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 8, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/hack/tool/github.com/k0sproject/k0sctl-0.19.2 branch November 8, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants