-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/k0sproject/k0sctl from 0.19.0 to 0.19.2 in /hack/tool #5157
build(deps): bump github.com/k0sproject/k0sctl from 0.19.0 to 0.19.2 in /hack/tool #5157
Conversation
Need to check the OS tests first. |
Still not working:
@kke Mind to have a look? |
This pull request has merge conflicts that need to be resolved. |
7bab297
to
d8df62e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bumps [github.com/k0sproject/k0sctl](https://github.com/k0sproject/k0sctl) from 0.19.0 to 0.19.2. - [Release notes](https://github.com/k0sproject/k0sctl/releases) - [Commits](k0sproject/k0sctl@v0.19.0...v0.19.2) --- updated-dependencies: - dependency-name: github.com/k0sproject/k0sctl dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
d8df62e
to
7f71323
Compare
All SANs manipulation was removed from k0sctl as k0s does it on its own. Looks like some of them were not redundant. |
It was made in k0sproject/k0sctl@fd0ba50
|
k0s does this: // Sans return the given SANS plus all local addresses and externalAddress if given
func (a *APISpec) Sans() []string {
sans, _ := iface.AllAddresses()
sans = append(sans, a.Address)
sans = append(sans, a.SANs...)
if a.ExternalAddress != "" {
sans = append(sans, a.ExternalAddress)
}
return stringslice.Unique(sans)
} |
Could it be that 23.22.x.x is not returned from sans = append(sans, a.Address) k0sctl sets this to the private address of the node or the public one if not set. |
Should k0sctl maybe default |
Adding the public address to SANs could make sense since it could be a NAT address not actually existing on the host. |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps github.com/k0sproject/k0sctl from 0.19.0 to 0.19.2.
Release notes
Sourced from github.com/k0sproject/k0sctl's releases.
Commits
081dfeb
Fix k0s CPLB config parsing interface conversion panic (#776)0646847
Use go1.23.2, update dependencies (#774)09cfd11
Extract etcd membership check into a separate phase (#770)4c6450d
Merge pull request #772 from k0sproject/validate-connection-vrrp-ipfd0ba50
Remove all SANs manipulation as k0s does it on its own3f9f91d
Validate worker connectivity to cluster-internal addresses6b9054b
Consider k0s onlyBindToAddress option when building API URLsec2a1f9
Fall back to CPLB virtual address in external API URLb8a2fd0
Merge pull request #769 from k0sproject/modifiable-applyaction5bc7203
Make Apply action phase list modifiable before Run()Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)