[Backport release-1.30] bug: disable oci bundle loader on byocri #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oci bundle loader does not support bring your own cri as we can't possibly know where the containerd socket is. we should revisit this in the future and maybe attempt to contact through cri socket instead. Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com> (cherry picked from commit a203f26)
twz123
added
bug
jnummelin
approved these changes
Sep 24, 2024
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-1.29
git worktree add -d .worktree/backport-5005-to-release-1.29 origin/release-1.29
cd .worktree/backport-5005-to-release-1.29
git switch --create backport-5005-to-release-1.29
git cherry-pick -x 9fac1227ec5e7e1a2e9d1add7c8932049bdc572f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport to
release-1.30: