Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: disable oci bundle loader on byocri #4941

Merged

Conversation

ricardomaraschini
Copy link
Contributor

Description

OCI bundle loader does not support bring your own CRI as we can't possibly know where the containerd socket is. We should revisit this in the future and maybe attempt contact through CRI socket instead.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

oci bundle loader does not support bring your own cri as we can't
possibly know where the containerd socket is. we should revisit this
in the future and maybe attempt to contact through cri socket instead.

Signed-off-by: Ricardo Maraschini <ricardo.maraschini@gmail.com>
@twz123 twz123 added bug Something isn't working area/worker area/containers backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch labels Sep 5, 2024
@twz123 twz123 merged commit 570a556 into k0sproject:main Sep 5, 2024
90 checks passed
@k0s-bot
Copy link

k0s-bot commented Sep 5, 2024

Backport failed for release-1.30, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-1.30
git worktree add -d .worktree/backport-4941-to-release-1.30 origin/release-1.30
cd .worktree/backport-4941-to-release-1.30
git switch --create backport-4941-to-release-1.30
git cherry-pick -x a203f26ed0f76640f7378631b26416042647f44e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/containers area/worker backport/release-1.30 PR that needs to be backported/cherrypicked to the release-1.30 branch bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants