Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions COMMIT_MESSAGE_ISSUE_5925.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
fix(exec): keep PATH for npm workspace commands (#5925)
15 changes: 8 additions & 7 deletions PR_BODY.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
## Overview
- AutoRunPhase now carries struct payloads; controller exposes helpers (`is_active`, `is_paused_manual`, `resume_after_submit`, `awaiting_coordinator_submit`, `awaiting_review`, `in_transient_recovery`).
- ChatWidget hot paths (manual pause, coordinator routing, ESC handling, review exit) rely on helpers/`matches!` instead of raw booleans.
## Summary
- preserve `PATH` (and `NVM_DIR` when present) across shell environment filtering so workspace commands like `npm` remain available
- continue to respect `use_profile` so commands run through the user's login shell when configured
- add unit coverage for the environment builder and an integration-style npm smoke test (skips automatically if npm is unavailable)

## Tests
- `./build-fast.sh`
## Testing
- ./build-fast.sh
- cargo test -p code-core --test npm_command *(fails: local cargo registry copy of `cc` 1.2.41 is missing generated modules; clear/update the registry and rerun)*

## Follow-ups
- See `docs/auto-drive-phase-migration-TODO.md` for remaining legacy-flag removals and snapshot coverage.
Closes #5925.
10 changes: 10 additions & 0 deletions PR_BODY_ISSUE_5925.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
## Summary
- always preserve `PATH` (and `NVM_DIR`, if present) through `ShellEnvironmentPolicy` filtering so npm remains discoverable
- continue to wrap commands in the user shell when `use_profile` is enabled, ensuring profile-managed Node installations work
- add unit coverage for the environment builder and integration-style npm smoke tests (skipped automatically when npm is absent)

## Testing
- ./build-fast.sh
- cargo test -p code-core --test npm_command *(fails: local cargo registry copy of `cc` 1.2.41 is missing generated modules; clear/update the crate cache and rerun)*

Closes #5925.
134 changes: 89 additions & 45 deletions code-rs/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions code-rs/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,8 @@ strip = "symbols"
codegen-units = 1

[patch.crates-io]
cc = { git = "https://github.com/alexcrichton/cc-rs", rev = "d740f9b1f5d65b09ccac41cac2e40caa8958e348" }
rmcp = { path = "third_party/rmcp-0.8.3" }
# ratatui = { path = "../../ratatui" }
ratatui = { git = "https://github.com/nornagon/ratatui", branch = "nornagon-v0.29.0-patch" }

Expand Down
Loading
Loading