Skip to content

Conversation

@zemaj
Copy link

@zemaj zemaj commented Oct 30, 2025

Summary

  • OAuth metadata discovery dropped server query parameters so remote MCP OAuth servers (e.g. Supabase) served 404s and the CLI fell back to bogus /authorize URLs
  • patch the vendored rmcp client to retain the original query string when probing /.well-known/oauth-authorization-server and add a regression test that fails without it
  • vendor the patched crate plus a git cc dependency so metadata discovery and downstream builds succeed

Testing

  • cargo test -p code-rmcp-client discover_metadata_preserves_query_parameters -- --nocapture
  • ./build-fast.sh

Closes openai#5953.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +82 to +84
for (key, value) in preserved_vars {
env_map.entry(key).or_insert(value);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Respect inherit=none when restoring PATH/NVM

The new logic unconditionally reinserts any discovered PATH and NVM_DIR entries after filtering. When ShellEnvironmentPolicyInherit::None is selected, the caller expects a completely clean environment except for explicit overrides (see test_inherit_none). The loop re‑adding preserved vars ignores that contract and now leaks the parent process’s PATH/NVM_DIR into supposedly isolated executions. This both regresses existing behaviour and breaks environments that relied on inherit: None for sandboxing. Consider skipping the preservation step when the policy forbids inheritance or when the variables were deliberately excluded.

Useful? React with 👍 / 👎.

@zemaj zemaj closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remote MCP] Error when trying to log in - Error: Metadata error:

2 participants