Skip to content

Conversation

@zemaj
Copy link

@zemaj zemaj commented Oct 30, 2025

Summary

  • abort PTY reader tasks when a shell session is force-killed (timeout or user interrupt) so we don't wait forever for EOF from orphaned grandchildren
  • join stdout/stderr readers with a short timeout during normal completion to avoid indefinite hangs when a child leaves pipes open
  • add an exec regression test that kills a long-running python loop and ensures kill_all() unblocks pending exec requests

Testing

  • ./build-fast.sh
  • cargo test -p code-core --test dotnet_build_hang (fails: upstream cc 1.2.41 crate is missing generated modules in the local cargo registry; clear/update the registry and rerun)

Closes openai#5946.

@zemaj zemaj closed this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dotnet build execution takes indefinite amount of time without success

2 participants