fix(tui/mcp): keep menu selection in view #366
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ts < anchor_ts || (ts == anchor_ts && sid < anchor_id) { | ||
| anchor_passed = true; | ||
| } else { | ||
| continue; |
There was a problem hiding this comment.
Traversal now ranks conversations by filesystem modification time, but the pagination cursor and skip logic still compare only the timestamp encoded in the filename. The loop marks anchor_passed once it sees a record with ts < anchor_ts; any files with a newer timestamp but an older mtime are skipped before this happens and will never be yielded on subsequent pages. For example, with three files (mtime 20, ts Aug), (mtime 15, ts Jul), (mtime 10, ts Sep), requesting the Aug entry first means the Sep session can never appear on later pages. Pagination will drop or reorder sessions unless the cursor also tracks the mtime (or the anchor filter is applied after sorting by mtime).
Useful? React with 👍 / 👎.
|
Preview Build rerun triggered after #364 merged; watching for green checks. |
|
Fresh Preview Build queued with updated toolchain after #364 merged; watching for green checks. |
|
Preview Build rerun queued with Rust 1.90.0 plus MUSL targets after #370 merged. Tracking run: https://github.com/just-every/code/actions/runs/18870471268 |
zemaj
force-pushed
the
main
branch
2 times, most recently
from
804b5ad to
b7927a2
Compare
Summary
Paragraph::scrollso the highlight stays visibleTesting
Fixes #305