fixed 'change password' feature for Jupyterhub version 1.0.0#23
Merged
GeorgianaElena merged 1 commit intojupyterhub:masterfrom Aug 24, 2019
Merged
fixed 'change password' feature for Jupyterhub version 1.0.0#23GeorgianaElena merged 1 commit intojupyterhub:masterfrom
GeorgianaElena merged 1 commit intojupyterhub:masterfrom
Conversation
Member
|
This is awesome 🍀 ! Thanks a lot @ABVitali and congratulations on your first PR 🚀 🎊 |
This was referenced Aug 27, 2019
This was referenced Oct 18, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to use firstuseauthenticator with Jupyterhub version 1.0.0 locally I had a problem when I tested password change.
Unfortunately, I don't remember in which other issue I found the explanation that I used to apply the change to the code but I tested it and it seems to work.
It is my first try of a contribution so please be patient if there is something missing in the contribution procedure.
The error I had in jupyterhub logs with the last version of the code (0.12) was:
After the fix I have:
and the web page correctly says password changed instead of internal server error 500