Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change password doesn't work #375

Closed
efedorov-dart opened this issue Jun 13, 2019 · 3 comments
Closed

Change password doesn't work #375

efedorov-dart opened this issue Jun 13, 2019 · 3 comments

Comments

@efedorov-dart
Copy link

efedorov-dart commented Jun 13, 2019

I'm trying to change admin password. And It seems impossible to do!
1.
When access: /hub/auth/change-password from logged in user it produces:

Jun 13 15:41:38 paytonstudio python3[20278]: [I 2019-06-13 15:41:38.474 JupyterHub log:174] 200 GET /hub/auth/change-password (admin@192.168.11.155) 47.65ms
Jun 13 15:41:45 paytonstudio python3[20278]: [E 2019-06-13 15:41:45.047 JupyterHub web:1788] Uncaught exception POST /hub/auth/change-password (192.168.11.155)
Jun 13 15:41:45 paytonstudio python3[20278]: HTTPServerRequest(protocol='https', host='st....xyz', method='POST', uri='/hub/auth/change-password', version='HTTP/1.1', remote_ip='192.168.11.155')
Jun 13 15:41:45 paytonstudio python3[20278]: Traceback (most recent call last):
Jun 13 15:41:45 paytonstudio python3[20278]: File "/opt/tljh/hub/lib/python3.6/site-packages/tornado/web.py", line 1699, in _execute
Jun 13 15:41:45 paytonstudio python3[20278]: result = await result
Jun 13 15:41:45 paytonstudio python3[20278]: File "/opt/tljh/hub/lib/python3.6/site-packages/firstuseauthenticator/firstuseauthenticator.py", line 53, in post
Jun 13 15:41:45 paytonstudio python3[20278]: self.authenticator.reset_password(user.name, new_password)
Jun 13 15:41:45 paytonstudio python3[20278]: AttributeError: 'coroutine' object has no attribute 'name'
Jun 13 15:41:45 paytonstudio python3[20278]:

  1. I changed is using system passwd:
    sudo passwd jupyter-admin
    Enter new password: ....

But the password for admin remains the same. I can login with initial default insecure password.

@efedorov-dart
Copy link
Author

It seems you forgot to add await on self.get_current_user() in firstuseauthenticator.py

@efedorov-dart
Copy link
Author

yep. That fixes.
And also there are no link to change password page.

@GeorgianaElena
Copy link
Member

This should now be fixed by jupyterhub/firstuseauthenticator#23, (originally started in jupyterhub/firstuseauthenticator#20).
Thanks a lot @efedorov-dart and @ABVitali for woking on this 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants