Skip to content

Save temp file next to notebook for WebPDF export #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Save temp file next to notebook for WebPDF export #2220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions nbconvert/exporters/webpdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ def _template_name_default(self):
""",
).tag(config=True)

def run_playwright(self, html):
def run_playwright(self, html, path=None):
"""Run playwright."""

async def main(temp_file):
Expand Down Expand Up @@ -143,7 +143,9 @@ async def main(temp_file):
# file to be opened by a separate process. So we must close it first
# before calling Chromium. We also specify delete=False to ensure the
# file is not deleted after closing (the default behavior).
temp_file = tempfile.NamedTemporaryFile(suffix=".html", delete=False)
temp_file = tempfile.NamedTemporaryFile(
suffix=".html", prefix=".webpdf-", dir=path, delete=False
)
with temp_file:
temp_file.write(html.encode("utf-8"))
try:
Expand All @@ -169,9 +171,10 @@ def run_coroutine(coro):
def from_notebook_node(self, nb, resources=None, **kw):
"""Convert from a notebook node."""
html, resources = super().from_notebook_node(nb, resources=resources, **kw)
path = resources.get("metadata", {}).get("path")

self.log.info("Building PDF")
pdf_data = self.run_playwright(html)
pdf_data = self.run_playwright(html, path)
self.log.info("PDF successfully created")

# convert output extension to pdf
Expand Down
Loading