Save temp file next to notebook for WebPDF export #2220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By putting the HTML file in the same location as the notebook, any relative file paths correctly resolve. This change saves us from needing to convert relative paths to absolute. This slightly changes behavior by creating the temp file in the user's working directory. We already make sure we delete this temp file, and by adding the ".webpdf-" prefix to make it hidden, less-technical users should never see this file at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By putting the HTML file in the same location as the notebook, any
relative file paths correctly resolve. This change saves us from needing
to convert relative paths to absolute.
This slightly changes behavior by creating the temp file in the user's
working directory. We already make sure we delete this temp file, and by
adding the
".webpdf-"prefix to make it hidden, less-technical usersshould never see this file at all.