Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voila incorporation #42

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Voila incorporation #42

merged 1 commit into from
Oct 21, 2019

Conversation

SylvainCorlay
Copy link
Member

@SylvainCorlay SylvainCorlay commented Oct 14, 2019

We propose to make Voilà an official Jupyter subproject.

@SylvainCorlay SylvainCorlay changed the title Jupyter declarative widgets incorporation Voila incorporation Oct 14, 2019
@Zsailer
Copy link
Member

Zsailer commented Oct 14, 2019

To be explicit with my "approval", I both approve the document (reviewed it for typos and think it's ready for merge) and vote in favor of accepting the proposal. 😄 I'm not sure how to best signal those two actions on Github.

@bollwyvl bollwyvl self-requested a review October 15, 2019 00:15
@betatim
Copy link
Member

betatim commented Oct 15, 2019

Should we use this JEP to test drive the JEP Process? Instead of winging it without a process.

I say test drive because JEP-29 has been merged but is still marked as draft. If the status should be "accepted" then read this as a reminder that there is a process that should be used ;)

@SylvainCorlay
Copy link
Member Author

Thanks @betatim. It does not seem that the new process provides a method to incorporate existing projects as subprojects though. The new jupyter_server proposal is pretty much going through the new process.

Copy link
Member

@jasongrout jasongrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really excited about this.

@takluyver
Copy link
Member

There are two files which look ~identical at a glance. Is that deliberate? 😕

@SylvainCorlay
Copy link
Member Author

There seems to have been a rebasing issue. Fixing this now.

@SylvainCorlay
Copy link
Member Author

There are two files which look ~identical at a glance. Is that deliberate? confused

There seems to have been a rebasing issue. Fixing this now.

done.

@SylvainCorlay
Copy link
Member Author

Gentle ping @mpacer @ellisonbg @willingc - are you fine with this as it is?
CC @jhamrick @Carreau @Ruv7

@ellisonbg
Copy link
Contributor

I approve

@Ruv7
Copy link

Ruv7 commented Oct 21, 2019

Sorry for the delay @SylvainCorlay - I abstain from this vote.

@SylvainCorlay
Copy link
Member Author

SylvainCorlay commented Oct 21, 2019

To summarize the results of the votes:

  • We got 11 approvals from SC members here (Brian, Fernando, Paul, Min, Peter, Afshin, Jason, Thomas, Kyle, Damian, Steve), 1 explicit abstension (Ana). 2 more approvals by members of the steering council on the SC mailing list (M, Carol). Matthias and Jess have not voted on this.

  • Quoting the process for "proposal for incorporation": upon proposal, allow a week for potential objections (explicit agreement welcome, of course). If no objections, treat silence as agreement. So it seems that we got an approval here.

Also, many thanks to @Zsailer, @bollwyvl, @lheagy, @jtpio, @martinRenou for reviewing the JEP PR and approving the proposal!

@jasongrout
Copy link
Member

Sounds like we've passed with flying colors. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.