Add voila to website #357
Merged
Add voila to website #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainCorlay
commented
Dec 16, 2019
| -moz-transition: all .05s ease; | ||
| -ms-transition: all .05s ease; | ||
| -o-transition: all .05s ease; | ||
| transition: all .05s ease; |
There was a problem hiding this comment.
.5s was really too slow.
SylvainCorlay
commented
Dec 16, 2019
| @@ -188,7 +211,7 @@ <h3 class="section-header">Currently in use at</h3> | |||
| </div> | |||
| </section> | |||
| <section id="architecture"> | |||
| <div class="section-grey"> | |||
| <div class="section-white"> | |||
There was a problem hiding this comment.
Alternating grey and white. This requires making the logos a bit darker, hence the CSS change.
tgeorgeux
reviewed
Dec 17, 2019
Thanks for the review. This is great! |
afshin
approved these changes
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the JEP on the Voilà incorporation: jupyter/enhancement-proposals#42