Skip to content
This repository was archived by the owner on Jan 6, 2020. It is now read-only.

Fix #69 - remove strtolower() call on file path #70

Merged
merged 3 commits into from
Oct 24, 2019
Merged

Fix #69 - remove strtolower() call on file path #70

merged 3 commits into from
Oct 24, 2019

Conversation

junlarsen
Copy link
Owner

Closes #68
Closes #69

This PR fixes the issue presented in #68 with non-laravel environments
This PR should solve the issue presented in #69

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the development branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All PHPUnit tests are passing
  • New/updated tests are included (if applicable)

Other information:
Single unit test was updated because I changed the summoner name of that account

@junlarsen junlarsen merged commit 7dea3f3 into master Oct 24, 2019
@junlarsen junlarsen deleted the fix-69 branch October 24, 2019 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Key not being found in Production Version 1.5.1 breaks on non-Laravel environments
1 participant