Skip to content
This repository was archived by the owner on Jan 6, 2020. It is now read-only.

Laravel 6 support - I didn't test it yet #66

Merged
merged 2 commits into from
Oct 15, 2019
Merged

Conversation

elreco
Copy link
Contributor

@elreco elreco commented Oct 14, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the development branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All PHPUnit tests are passing
  • New/updated tests are included (if applicable)

Other information:

@elreco elreco changed the title I didn't test it yet Laravel 6 support - I didn't test it yet Oct 14, 2019
@elreco
Copy link
Contributor Author

elreco commented Oct 14, 2019

Hello,

I will test it on a fresh laravel 6 project. I keep you update.

@junlarsen junlarsen added the type:enhancement This issue is a new feature or request label Oct 14, 2019
@elreco
Copy link
Contributor Author

elreco commented Oct 15, 2019

image

It seems to work fine!

@junlarsen junlarsen merged commit af861cd into junlarsen:master Oct 15, 2019
@junlarsen
Copy link
Owner

junlarsen commented Oct 15, 2019

Thanks for your contribution :)

Released as 1.5.1

@junlarsen
Copy link
Owner

Will be reverting this as it broke on non-laravel systems. Will find an alternative way of using the env helper.

junlarsen added a commit that referenced this pull request Oct 24, 2019
Revert #66 - unwanted side effect
junlarsen added a commit that referenced this pull request Oct 24, 2019
junlarsen added a commit that referenced this pull request Oct 24, 2019
Fix #69 - remove strtolower() call on file path
Fix #66 - unwanted side effects in non-laravel envs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement This issue is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants