[vim] Don't pipe FZF_DEFAULT_COMMAND in Windows #969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmd.exe leaves the pipe hanging for the source command after fzf finishes so powershell and ag keep running and cmd.exe does not close. Putting
FZF_DEFAULT_COMMAND
in a batchfile hides the issue from cmd.exe so Vim is stuck waiting and Neovim does not run the exit callback. Letting fzf runFZF_DEFAULT_COMMAND
passes the responsibility of stopping the source program to fzf executable so Vim/Neovim don't have to wait for the source command to finish executing.This issue does not happen when running the fzf executable directly in the shell if
FZF_DEFAULT_COMMAND
is using powershell. ag still gets stuck.I did not consider ack because it requires perl and is too slow as a default command.