[neovim] Fix lcd when fzf job exits on Windows

[janlazo]

#896 did not consider relative filepaths in the exit handler because dir /s/b outputs absolute paths. I changed dict and temp to be part of the fzf job config to minimize issues with the exit handler when running :FZF consecutively in Neovim.

[junegunn]

Thanks, can you post a scenario that reproduces the problem for future reference?

[janlazo]

From #960 (with error redirection to powershell's /dev/null)
Requires #969 to not block Vim/Neovim

C:\Windows\System32>set FZF_DEFAULT_COMMAND=powershell.exe -NoLogo -NoProfile -Noninteractive -Command "Get-ChildItem -File -Recurse -Name 2> $null"
C:\Windows\System32>fzf
:: outputs a relative path

Compare with Vim/Neovim using the same minimal config. Vim changes the working directory but Neovim does not (without running lcd in the exit callback).

" assume fzf is installed in ~/.fzf
set rtp+=~/.fzf
runtime! plugin/fzf.vim
set noshellslash
FZF C:\Program\ Files\ (x86)\

[junegunn]

Can you check if we can use call s:pushd(self.dict) instead as in

fzf/plugin/fzf.vim

Lines 677 to 679 in 68bd410

	call s:pushd(self.dict)
	let lines = s:collect(self.temps)
	call s:callback(self.dict, lines)

?

[janlazo]

Didn't work. self.dict.prev_dir is set by the earlier s:pushd(a:dict)

[junegunn]

I see, thanks for the confirmation.

[junegunn]

Thanks!