Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FF7: Fix FIELD mode text box flickering rendering #525

Conversation

tangtang95
Copy link
Contributor

Summary

Apply bgfx reset view only when it is FF7 and in battle mode.

Motivation

The reset view caused a regression bug on FIELD mode where some text box when closed caused flickering. By applying the reset view only in battle mode, we avoid the issue and still keep this fix #508

ACKs

  • I have updated the Changelog.md file
  • I did test my code on FF7
  • I did test my code on FF8

@julianxhokaxhiu julianxhokaxhiu added the bug Something isn't working label Jan 12, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 1.15.0 milestone Jan 12, 2023
@julianxhokaxhiu julianxhokaxhiu self-requested a review January 12, 2023 08:25
@julianxhokaxhiu julianxhokaxhiu merged commit 6e45f90 into julianxhokaxhiu:master Jan 12, 2023
@julianxhokaxhiu
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants