Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FF7: Fix 3D model drawn over UI on BATTLE mode if lighting enabled #508

Merged
merged 1 commit into from
Oct 30, 2022
Merged

FF7: Fix 3D model drawn over UI on BATTLE mode if lighting enabled #508

merged 1 commit into from
Oct 30, 2022

Conversation

CosmosXIII
Copy link
Contributor

Fixes #131

Summary

The same fix as below but for lighting enabled:
#501

Motivation

The motivation is to make Kuraudo happy. The expected outcome is Kuraudo being happy.

ACKs

  • I have updated the Changelog.md file -> changelog was already changed by vertex
  • I did test my code on FF7
  • I did test my code on FF8

@julianxhokaxhiu julianxhokaxhiu self-requested a review October 30, 2022 08:45
@julianxhokaxhiu julianxhokaxhiu added bug Something isn't working enhancement New feature or request labels Oct 30, 2022
@julianxhokaxhiu julianxhokaxhiu added this to the 1.15.0 milestone Oct 30, 2022
@julianxhokaxhiu julianxhokaxhiu merged commit 0ed8263 into julianxhokaxhiu:master Oct 30, 2022
@julianxhokaxhiu
Copy link
Owner

Thank you!

@tangtang95 tangtang95 mentioned this pull request Jan 11, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

Assignees

@CosmosXIII CosmosXIII

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

[ FF7 ] Scorpion Sentinel drawn over UI
2 participants
@CosmosXIII @julianxhokaxhiu