-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop command doesn't seem to handle queue param properly #262
Comments
I'll have this fixed in the next 2-3 days. Thank you. |
Thank you for fixing it :) |
Fixed. Stay tuned for the next release. |
Please test, confirm it works, and get back to me. Thank you so much! |
I cannot do deep test right now (it's night here), but as far as I seen doing some quick tests it seems to work perfectly now. Thanks. |
Sorry, too tired yesterday, I've done the wrong test. |
Your test had multiple problems, including using $test instead of $v for the stopping. But it's revealed another bug that i'll look into. http://jsfiddle.net/hct1n31x/2/ |
yeah, sorry, cut & paste mistake. |
Done. Please test, confirm it works, and get back to me. Thank you so much! |
I've tested it locally and the bug seems solved now. However I've noticed that now if you use a custom queue it does not put animation data in velocity.tweensContainer object inside element's data structure, it is null now, while it fills it properly if you stay on default queue. |
Correct. If you see the new documentation on velocity's reverse command, you'll see a new change has been made: only the default effects queue affects the stored tweensContainer (which is used for reversal). Hopefully you don't mind figuring out a way around that :) |
ok. |
That is correct. Great question. It's not impossible for me to allow for multiple cached value chains (one per queue), but custom queuing is uncommon so it's not a concern of mine at this time. Sent from my phone
|
fair enough :) Thanks for the fix and explanations. |
Any time Sent from my phone
|
Dropped support for the easeBack and easeElastic easings. They are rarely used, look stupid, and take up a bunch of lines. Sped up bezier curve easing performance. Thanks, @gre. The display option now gets browser-prefixed if necessary. This inherently adds cross-browser support for the ‘flex’ value. Closes #257. Fixed bug where slideDown/up left excess inline styles on elements. Closes #260. cc @kpeatt, @scalvert. Allow passing an empty string to `display` to remove the inline style from the element. Closes #184. Shimmed version of jQuery’s $.dequeue() now accepts a raw DOM element *set* instead of just a single element. You can now stop custom queues individually. Closes #262.
Apply `overflow: hidden` when using the slide commands. Closes #260. Sequence (UI pack effect) options object no longer gets externally modified by Velocity. Closes #265. Fixed bug where tweens would jump when dequeuing custom queues. Closes #262. (The reverse command now only applies to the default effects queue; reverse cannot be used with custom queues or parallel queueing (queue: false).) Fixed unit conversion bug on the `x` property of SVG elements.
Hi,
If I have two concurrent tweens on the same target (obviously animating different CSS properties), for example:
$target.velocity({left: 200}, {duration: 1000, queue: 'a'}).dequeue('a');
$target.velocity({top: 300}, {duration: 2000, queue: 'b'}).dequeue('b');
then using stop command with the aim to halt only one of them does not seem to work:
$target.velocity('stop', 'a');
It halts all the queues, not only 'a'.
With jQuery native animate it works as expected, stopping only 'a' while the other tween continues its run.
The text was updated successfully, but these errors were encountered: