Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When flex is used as a display value it should be autoprefixed #257

Closed
kpeatt opened this issue Aug 21, 2014 · 12 comments
Closed

When flex is used as a display value it should be autoprefixed #257

kpeatt opened this issue Aug 21, 2014 · 12 comments

Comments

@kpeatt
Copy link

kpeatt commented Aug 21, 2014

Right now, the display function takes three supported values: auto, none, and block. It would be great if Velocity would take a flex option as well and autoprefix it to support older browsers.

@julianshapiro
Copy link
Owner

Display options aren't whitelisted. It should just work, no?

Sent from my phone

On Aug 21, 2014, at 12:37 PM, Kyle Peatt notifications@github.com wrote:

Right now, the display function takes three supported values: auto, none, and block. It would be great if Velocity would take a flex option as well.


Reply to this email directly or view it on GitHub.

@kpeatt
Copy link
Author

kpeatt commented Aug 21, 2014

I see the value get added sometime but it's not prefixed and it doesn't seem to get added consistently.

@julianshapiro
Copy link
Owner

If you can quickly confirm that the only issue is not auto-prefixing (which is not currently part of what velocity does for the display property), then I'll add that feature in.

@kpeatt
Copy link
Author

kpeatt commented Aug 21, 2014

Kay, looks like I lied about the inconsistency. Seems like the only issue is not autoprefixing.

@kpeatt kpeatt changed the title flex should be a supported display value When flex is used as a display value it should be autoprefixed Aug 21, 2014
@julianshapiro
Copy link
Owner

Okay. This will be fixed in the upcoming release. Ty.

@kpeatt
Copy link
Author

kpeatt commented Aug 21, 2014

Thanks!

@julianshapiro
Copy link
Owner

wait. this was never a prob to begin with. are you sure the browser you're testing on actually supports flex as you intend it to? see http://caniuse.com/#search=flex

@julianshapiro
Copy link
Owner

oh nvm this shit is wack

@kpeatt
Copy link
Author

kpeatt commented Aug 23, 2014

I didn't want to say wack... but it's pretty wack.

@julianshapiro
Copy link
Owner

Please test, confirm it works, and get back to me. Thank you so much!

@kpeatt
Copy link
Author

kpeatt commented Aug 24, 2014

Yep, works great. You're rad.

@zjrosen1
Copy link

+1 for this just working

Rycochet pushed a commit that referenced this issue Aug 3, 2020
Dropped support for the easeBack and easeElastic easings. They are
rarely used, look stupid, and take up a bunch of lines.

Sped up bezier curve easing performance. Thanks, @gre.

The display option now gets browser-prefixed if necessary. This
inherently adds cross-browser support for the ‘flex’ value. Closes #257.

Fixed bug where slideDown/up left excess inline styles on elements.
Closes #260. cc @kpeatt, @scalvert.

Allow passing an empty string to `display` to remove the inline style
from the element. Closes #184.

Shimmed version of jQuery’s $.dequeue() now accepts a raw DOM element
*set* instead of just a single element.

You can now stop custom queues individually. Closes #262.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants