Conversation
Handle missing ListFiles in JFFS2 filesystem
Create ProcessorEmulator.deps.json
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a GitHub Actions workflow to automate restoring, building, and testing the Processor-Emulator .NET solution on pushes and pull requests to main/master.
- Introduces a
.NET BuildCI pipeline with checkout, setup, restore, build, and test steps. - Configures Windows runners and uses .NET 6.0.
Comments suppressed due to low confidence (1)
.github/workflows/dotnet.yml:29
- The
continue-on-error: truesetting will prevent test failures from failing the workflow. Consider removing this or setting it to false so that failing tests block the build.
continue-on-error: true
| runs-on: windows-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
[nitpick] Consider adding a caching step (e.g., using actions/cache) for NuGet packages to speed up restore times in the workflow.
Owner
Author
|
This pull request adds a new GitHub Actions workflow to automate the build, test, and dependency restoration processes for the CI/CD Workflow Addition:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.