Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: hooks.js init moved to Server.init causes reading handleError of null #180

Closed
pham opened this issue Aug 26, 2022 · 0 comments · Fixed by #181
Closed

bug: hooks.js init moved to Server.init causes reading handleError of null #180

pham opened this issue Aug 26, 2022 · 0 comments · Fixed by #181
Labels
bug Something isn't working

Comments

@pham
Copy link
Contributor

pham commented Aug 26, 2022

Describe the Bug

SvelteKit 1.0.0-next.433 moved hooks.js init from Server.respond to Server.init (sveltejs/kit#6179) causes Firebase function to throw a TypeError:

⚠  functions: TypeError: Cannot read properties of null (reading 'handleError')
    at Object.handle_error (/proj/a/functions/ssr/index.js:57764:28)
    at respond (/proj/a/functions/ssr/index.js:57696:13)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Steps to Reproduce

  1. Bump @sveltejs/kit to version 1.0.0-next.433
  2. Build and run emulators
  3. Page breaks

Expected Behaviour

Should load up the page normally.

svelte-adapter-firebase version

0.14.2

sveltejs/kit version

1.0.0-next.443
@pham pham added the bug Something isn't working label Aug 26, 2022
pham added a commit to pham/svelte-adapter-firebase that referenced this issue Aug 27, 2022
@pham
fix(jthegedus#180): Prepend Server.init before calling `Server.resp…
888bf8e 
…ond`
pham added a commit to pham/svelte-adapter-firebase that referenced this issue Aug 27, 2022
@pham
fix(jthegedus#180): Prepend Server.init before calling `Server.resp…
012de01 
…ond`
pham added a commit to pham/svelte-adapter-firebase that referenced this issue Aug 27, 2022
@pham
fix(jthegedus#180): Prepend Server.init before calling `Server.resp…
139ee21 
…ond`
@pham pham mentioned this issue Aug 27, 2022
Merged
jthegedus pushed a commit that referenced this issue Sep 2, 2022
@pham
fix(#180): Prepend Server.init before calling Server.respond (#181)
5c937c9
@github-actions github-actions bot mentioned this issue Sep 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#180): Prepend Server.init before calling Server.respond pham/svelte-adapter-firebase
1 participant
@pham