Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move hooks.{js|ts} init to Server.init instead of Server.respond #6179

Merged
merged 22 commits into from
Aug 24, 2022

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Closes #6147.

  • Moved initialization of the hooks.js module to Server.init instead of Server.respond.
  • awaited Server.init in all adapters that use it (adapter-static doesn't).
  • Added dynamic environment variable support to prerendering. Added tests to verify this support.

TODO:

  • @Rich-Harris I left you a few letters in the comments of a couple adapters. They're not big deals, just something for you to be aware of and make a judgment on

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

🦋 Changeset detected

Latest commit: 5b9b0db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-vercel Patch
@sveltejs/kit Patch
@sveltejs/adapter-auto Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels way better. comments inline

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
@Rich-Harris
Copy link
Member

Moved the user_hooks = ... code back inside the middleware, because a) it was running before aliases were set up, and b) we need to do it per-request so that changes to src/hooks.js take effect without a server restart

@Rich-Harris Rich-Harris marked this pull request as ready for review August 24, 2022 14:25
@Rich-Harris Rich-Harris merged commit 64449a7 into master Aug 24, 2022
@Rich-Harris Rich-Harris deleted the 6147/sejohnson-move-hooks-init branch August 24, 2022 14:59
SG60 added a commit to SG60/kit-433-error that referenced this pull request Aug 26, 2022
Required since sveltejs/kit#6179, as hooks.js
are initialized in server.init()
SG60 added a commit to SG60/kit-433-error that referenced this pull request Aug 26, 2022
Required since sveltejs/kit#6179, as hooks.js
are initialized in server.init()
SG60 added a commit to SG60/kit that referenced this pull request Aug 26, 2022
fmaclen added a commit to fmaclen/canutin-desktop that referenced this pull request Aug 26, 2022
As of `1.0.0-next.433` (sveltejs/kit#6179) the build script bundles the app incorrectly.

Specifics about the problem: sveltejs/kit#6325
Rich-Harris added a commit that referenced this pull request Aug 27, 2022
* Run server.init() for edge functions on Vercel.

Required since #6179.

Closes #6308.

* changeset

* changes

* remove async keyword

* Update .changeset/strong-kangaroos-work.md

* netlify edge functions

* changeset

Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@benmccann benmccann added breaking change adapters - general Support for functionality general to all adapters labels Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters - general Support for functionality general to all adapters breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A way to validate things on server initialization
3 participants