add more complex test

lib/rules/forbid-component-props.js

@@ -151,21 +151,31 @@ module.exports = {
         return false;
       }
 
-      function checkIsTagForbidden() {
-        if (options.allowPatternList.length > 0) {
-          return options.allowPatternList.every(
-            (pattern) => !minimatch(tagName, pattern)
-          );
+      function checkIsTagForbiddenByAllowPatternList() {
+        if (options.allowPatternList.length === 0) {
+          return true;
         }
 
-        // disallowList should have a least one item (schema configuration)
-        return options.disallowList.length > 0
-          ? options.disallowList.indexOf(tagName) !== -1
-          : options.allowList.indexOf(tagName) === -1;
+        return options.allowPatternList.every(
+          (pattern) => !minimatch(tagName, pattern)
+        );
       }
 
+      function checkIsTagForbiddenByAllowList() {
+        return options.allowList.indexOf(tagName) === -1;
+      }
+
+      function checkIsTagForbiddenByAllowOptions() {
+        return checkIsTagForbiddenByAllowPatternList() && checkIsTagForbiddenByAllowList();
+      }
+
+      // disallowList should have a least one item (schema configuration)
+      const isTagForbidden = options.disallowList.length > 0
+        ? options.disallowList.indexOf(tagName) !== -1
+        : checkIsTagForbiddenByAllowOptions();
+
       // if the tagName is undefined (`<this.something>`), we assume it's a forbidden element
-      return typeof tagName === 'undefined' || checkIsTagForbidden();
+      return typeof tagName === 'undefined' || isTagForbidden;
     }
 
     return {

tests/lib/rules/forbid-component-props.js

@@ -250,33 +250,15 @@ ruleTester.run('forbid-component-props', rule, {
         },
       ],
     },
-    {
-      code: `
-        const rootElement = (
-          <Root>
-            <SomeIcon className="size-lg" />
-            <AnotherIcon className="size-lg" />
-          </Root>
-        );
-      `,
-      options: [
-        {
-          forbid: [
-            {
-              propName: 'className',
-              allowedForPatterns: ['*Icon'],
-            },
-          ],
-        },
-      ],
-    },
     {
       code: `
         const rootElement = (
           <Root>
             <SomeIcon className="size-lg" />
             <AnotherIcon className="size-lg" />
             <SomeSvg className="size-lg" />
+            <UICard className="size-lg" />
+            <UIButton className="size-lg" />
           </Root>
         );
       `,
@@ -285,7 +267,7 @@ ruleTester.run('forbid-component-props', rule, {
           forbid: [
             {
               propName: 'className',
-              allowedForPatterns: ['*Icon', '*Svg'],
+              allowedForPatterns: ['*Icon', '*Svg', 'UI*'],
             },
           ],
         },
@@ -300,6 +282,7 @@ ruleTester.run('forbid-component-props', rule, {
             <SomeSvg className="size-lg" />
             <UICard className="size-lg" />
             <UIButton className="size-lg" />
+            <ButtonLegacy className="size-lg" />
           </Root>
         );
       `,
@@ -308,6 +291,7 @@ ruleTester.run('forbid-component-props', rule, {
           forbid: [
             {
               propName: 'className',
+              allowedFor: ['ButtonLegacy'],
               allowedForPatterns: ['*Icon', '*Svg', 'UI*'],
             },
           ],