Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default value of block kwarg #269

Closed
3 tasks done
jsocol opened this issue Dec 3, 2022 · 0 comments · Fixed by #271
Closed
3 tasks done

Change default value of block kwarg #269

jsocol opened this issue Dec 3, 2022 · 0 comments · Fixed by #271
Assignees
@jsocol
Labels
semver:major
Milestone
4.0

Comments

@jsocol
Copy link
Owner

jsocol commented Dec 3, 2022 •
edited
Loading

Per the discussion in #229, as part of this major/breaking version, the default behavior of the @ratelimit decorator should be to block requests.

  • Switch default
  • Update tests
  • Update documentation
@jsocol jsocol added this to the 4.0 milestone Dec 3, 2022
@jsocol jsocol self-assigned this Dec 3, 2022
jsocol added a commit that referenced this issue Dec 4, 2022
@jsocol
Switch default behavior to block=True
b6d8bf1 
Previous versions defaulted to block=False for the decorator, which was
surprising and lead to more than a few issues being filed. This change
reverses the default, setting block=True on the decorator. To opt into
the previous behavior, use block=False.

Fixes #269
@jsocol jsocol mentioned this issue Dec 4, 2022
Merged
@jsocol jsocol mentioned this issue Apr 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsocol jsocol

Labels
semver:major
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

Switch default behavior to block=True jsocol/django-ratelimit
1 participant
@jsocol