Switch default behavior to block=True #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous versions defaulted to block=False for the decorator, which was surprising and lead to more than a few issues being filed. This change reverses the default, setting block=True on the decorator. To opt into the previous behavior, use block=False. Fixes #269
jsocol
force-pushed
the
default-to-block
branch
from
7d8e317 to
b6d8bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions defaulted to block=False for the decorator, which was
surprising and lead to more than a few issues being filed. This change
reverses the default, setting block=True on the decorator. To opt into
the previous behavior, use block=False.
Fixes #269