Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop obsolete (and broken urlgrabber dependency) #867

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Jan 24, 2023

See #866

Copy link
Member

@knorth55 knorth55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#812 is also pointing out this broken dependencies.

@knorth55 knorth55 added the bug label Mar 3, 2023
Copy link
Contributor

@pazeshun pazeshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this PR to make CI with Noetic pass:
https://github.com/start-jsk/jsk_apc/pull/2767/files#diff-366b1e4a3dd2a097dfbd79cbb5181f2a3a1fdc364422f6fd8bfbd9ba4f648bd8R96-R100
Without this PR, rosdep install returns an error because python3-urlgrabber does not exist.

@k-okada k-okada merged commit 851ad17 into jsk-ros-pkg:master Sep 19, 2023
@k-okada
Copy link
Member

k-okada commented Sep 19, 2023

#812 also confirms that urlgrabber is not used in jsk_visualization package. @adivardi also found the lack of urllib in jsk_interactive_test (Thank you!). But fortunatelly(unfortunatelly?) the jsk_interactive_test does not contain any test code, so it is not anurgent issues and I'll leave it alone for now.

v4hn added a commit to v4hn/ros-o-builder that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants