Skip to content

Comments

Manage Embedded Fields with NO BC Breaks in master#2

Open
jsamouh wants to merge 159 commits intomasterfrom
nested-embed-field-filter
Open

Manage Embedded Fields with NO BC Breaks in master#2
jsamouh wants to merge 159 commits intomasterfrom
nested-embed-field-filter

Conversation

@jsamouh
Copy link
Owner

@jsamouh jsamouh commented Mar 29, 2017

Q A
Bug fix? yes/no
New feature? yes/no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets api-platform#1234, api-platform#5678
License MIT
Doc PR api-platform/docs#1234

Please update this template with something that matches your PR

@jsamouh jsamouh force-pushed the nested-embed-field-filter branch 3 times, most recently from bcd0c73 to 60783a7 Compare April 6, 2017 08:23
They disabled logs when nb_lines > 10000, which is our case, this helps
debugging
@jsamouh jsamouh force-pushed the nested-embed-field-filter branch from 60783a7 to 7f5a2d7 Compare April 6, 2017 12:19
dunglas and others added 15 commits April 7, 2017 12:08
* Removed unneeded catch on ResourceClassNotFound

* fix FilterEagerLoading when entity has FETCH_EAGER with no force eager
ReflectionExtractor::getProperties() returns $id instead of $Id. It is bad naming convention, but is possible

```
use ApiPlatform\Core\Annotation\ApiProperty;
use Doctrine\ORM\Mapping as ORM;

class Entity {
    /**
     * @var string The dummy Guid
     *
     * @Orm\Column(nullable=true)
     * @ApiProperty()
     */
    protected $Id;

    public function getId()
    {
        return $this->Id;
    }
}
```
Refresh routes when an entity is created
…rs-type-conversion

Normalize identifiers to the correct type
dunglas and others added 23 commits May 17, 2017 14:41
…p_cs_fixer

Add the header_comment rule to the PHP-CS-Fixer's configuration
Disable eager loading partial fetch by default api-platform#1069
specify left join for filter associations if there was a previous left join
…r_ignored_attributes

Fix ignoring attributes for the abstract item normalizer
Fix CS, make Travis green again
Swagger documentation normalizer revert throw when method is not supp…
Also resolves conflicts with existing subresources on a property having
the same name
Fix route name resolving with subresources
@soyuka soyuka force-pushed the nested-embed-field-filter branch 2 times, most recently from a6b08d4 to b7d48bf Compare May 23, 2017 12:49
@soyuka soyuka force-pushed the nested-embed-field-filter branch from b7d48bf to c29a322 Compare May 23, 2017 13:59
@soyuka soyuka force-pushed the nested-embed-field-filter branch from c29a322 to 5dc1b08 Compare May 23, 2017 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.