Skip to content

Comments

specify left join for filter associations if there was a previous left join#1128

Merged
soyuka merged 1 commit intoapi-platform:2.0from
soyuka:fix/add-join-once-left
May 19, 2017
Merged

specify left join for filter associations if there was a previous left join#1128
soyuka merged 1 commit intoapi-platform:2.0from
soyuka:fix/add-join-once-left

Conversation

@soyuka
Copy link
Member

@soyuka soyuka commented May 18, 2017

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #789 (comment)
License MIT
Doc PR n/a

see #789 (comment)

@soyuka soyuka added the bug label May 18, 2017
@soyuka
Copy link
Member Author

soyuka commented May 18, 2017

@wadjeroudi may you test this patch to see if it fixes your issue? Thanks!

@wadjeroudi
Copy link

@soyuka man you're not a lazy guy for sure 👍
Will test this afternoon and tell you. Thank you !

@soyuka
Copy link
Member Author

soyuka commented May 18, 2017

you're not a lazy guy for sure

Wrong, a good developer should be lazy by definition 😄

@wadjeroudi
Copy link

@soyuka it seems good for my use case. Thx.

@soyuka soyuka force-pushed the fix/add-join-once-left branch from 7d36bf3 to e114c46 Compare May 19, 2017 08:42
@soyuka soyuka merged commit 461ecd9 into api-platform:2.0 May 19, 2017
@soyuka soyuka deleted the fix/add-join-once-left branch May 19, 2017 09:51
hoangnd25 pushed a commit to hoangnd25/core that referenced this pull request Feb 23, 2018
specify left join for filter associations if there was a previous left join
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants