-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ntlm proxy auth #204
base: master
Are you sure you want to change the base?
Ntlm proxy auth #204
Conversation
hey @pariseed thanks for the PR, can you run |
Hi @jpillora done, let me know if it's ok :) |
Thanks! hopefully can merge soon |
Hey guys I remember looking into this and was going to make a few changes myself (though ran out of time):
@pariseed feel free to make these changes if you're up for it |
@jpillora as explained in the issue 149 i was not able to successfully use https://github.com/Azure/go-ntlmssp in order to correctly authenticate on ntlm proxys and in the issue i've already explained why this happen, beyond that the guys from launchdarkly didn't do anything of strange on their fork adding only the negotiations flag needed to let authentication work and if they in the future for any reason will messed up their things will be very easily for us untie from them. |
why?
variable casing is wrong oct 2020 i said that i want to make sure "we don't introduce many new dependencies" id be okay accepting a single dependency from Microsoft (Azure) - this means we copy the changes that in summary, the PR should include be the changes you've got right now, plus the fixes, plus this 100 line file from launchdarkly/go-ntlm-proxy-auth with the flag changes so we can use the original azure repo. i do open source in my free time, and time is very valuable, so if someone wants custom enhancements, then i need that someone to put in the work - while keeping chisel stable, without introducing bad dependencies, bugs, and bad code |
following almost all the suggestion argued in issue 149 this pull request enable chisel to connect on ntlm v2 proxies