-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chisel do not support ntlm proxy authentication #149
Comments
closing this issue because i solve the ntlm proxy auth with: i made a fork of chisel where i've implemented the above lib in chisel code. |
@pariseed why not a PR ? This issue is still valid and should not be closed |
@mpgn when i've opened this issue i've wait almost a month for an answer from @jpillora but while for other issue opened after that a response was provided for this issue nothing is come. |
Hey @pariseed I'd consider a PR, though I'd want to confirm the API beforehand, and also that we don't introduce many new dependencies |
Hi @jpillora i understood, i think that if you're sure to use the API there is no sense to forward a PR. add new regex syntax to recognize ntlm invocation If you change idea let me know and i will create a patch from this lines or a PR |
A few things changes that I'd request:
//optionally CONNECT proxy
if c.httpProxyURL != nil {
if isntlm == true {
ntlmDialContext := ntlm.WrapDialContext(daler.DialContext, ntlmurl, ntlmusr, ntlmpwd, ntlmdomain)
d.NetDialContext = ntlmDialContext
d.Proxy = func(*http.Request) (*url.URL, error) {
return c.httpProxyURL, nil
}
} else {
d.Proxy = func(*http.Request) (*url.URL, error) {
return c.httpProxyURL, nil
}
}
} to //optionally CONNECT proxy
if c.httpProxyURL != nil {
if isntlm {
d.NetDialContext = ntlm.WrapDialContext(daler.DialContext, ntlmurl, ntlmusr, ntlmpwd, ntlmdomain)
}
d.Proxy = func(*http.Request) (*url.URL, error) {
return c.httpProxyURL, nil
}
}
|
@jpillora i've just forwarded the PR 104 to you. |
Reopened this issue, because after one year and PR 204 ignored nothing is changed |
Commented on the PR 👍
…On Tue, 27 Apr 2021 at 12:59 am PD ***@***.***> wrote:
Reopened this issue, because after one year and PR 204
<#204> ignored nothing is changed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE2X43AKSFUQLBLDTUUXMTTKV5VZANCNFSM4MEUJEGA>
.
|
is in roadmap the possibility to introduce support for ntlm proxy authentication ?
The text was updated successfully, but these errors were encountered: