Skip to content

[6.0] Reducing PHPStan baseline #45854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 6.0-dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
use Joomla\CMS\Layout\LayoutHelper;
use Joomla\CMS\Router\Route;
use Joomla\Component\Actionlogs\Administrator\Helper\ActionlogsHelper;
use Joomla\Component\Actionlogs\Administrator\View\Actionlogs\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Actionlogs\Administrator\View\Actionlogs\HtmlView $this */

$listOrder = $this->escape($this->state->get('list.ordering'));
$listDirn = $this->escape($this->state->get('list.direction'));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@

use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Associations\Administrator\View\Association\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Associations\Administrator\View\Association\HtmlView $this */

/** @var Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->getDocument()->getWebAssetManager();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@
use Joomla\CMS\Router\Route;
use Joomla\CMS\Session\Session;
use Joomla\Component\Guidedtours\Administrator\Extension\GuidedtoursComponent;
use Joomla\Component\Guidedtours\Administrator\View\Steps\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Guidedtours\Administrator\View\Steps\HtmlView $this */

/** @var \Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->getDocument()->getWebAssetManager();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@
use Joomla\CMS\Layout\LayoutHelper;
use Joomla\CMS\Router\Route;
use Joomla\CMS\Session\Session;
use Joomla\Component\Guidedtours\Administrator\View\Tours\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Guidedtours\Administrator\View\Tours\HtmlView $this */

/** @var \Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->getDocument()->getWebAssetManager();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@
use Joomla\CMS\Router\Route;
use Joomla\CMS\Uri\Uri;
use Joomla\CMS\Version;
use Joomla\Component\Joomlaupdate\Administrator\View\Joomlaupdate\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Joomlaupdate\Administrator\View\Joomlaupdate\HtmlView $this */

/** @var \Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->getDocument()->getWebAssetManager();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\Updater\Update;
use Joomla\CMS\Utility\Utility;
use Joomla\Component\Joomlaupdate\Administrator\View\Joomlaupdate\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Joomlaupdate\Administrator\View\Upload\HtmlView $this */

/** @var \Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->getDocument()->getWebAssetManager();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@
use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Scheduler\Administrator\View\Select\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Scheduler\Administrator\View\Select\HtmlView $this */

$app = $this->app;

Expand Down
3 changes: 1 addition & 2 deletions administrator/components/com_scheduler/tmpl/task/edit.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@
use Joomla\CMS\Layout\LayoutHelper;
use Joomla\CMS\Router\Route;
use Joomla\Component\Scheduler\Administrator\Task\TaskOption;
use Joomla\Component\Scheduler\Administrator\View\Task\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Scheduler\Administrator\View\Task\HtmlView $this */

$wa = $this->getDocument()->getWebAssetManager();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,8 @@
use Joomla\CMS\Session\Session;
use Joomla\Component\Scheduler\Administrator\Scheduler\Scheduler;
use Joomla\Component\Scheduler\Administrator\Task\Status;
use Joomla\Component\Scheduler\Administrator\View\Tasks\HtmlView;

/** @var HtmlView $this*/
/** @var \Joomla\Component\Scheduler\Administrator\View\Tasks\HtmlView $this*/

/** @var \Joomla\CMS\WebAsset\WebAssetManager $wa */
$wa = $this->getDocument()->getWebAssetManager();
Expand Down
3 changes: 1 addition & 2 deletions administrator/components/com_users/tmpl/captive/select.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\CMS\Uri\Uri;
use Joomla\Component\Users\Administrator\View\Captive\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Administrator\View\Captive\HtmlView $this */

$shownMethods = [];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Users\Administrator\View\Method\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Administrator\View\Method\HtmlView $this */

HTMLHelper::_('bootstrap.tooltip', '.hasTooltip');

Expand Down
3 changes: 1 addition & 2 deletions administrator/components/com_users/tmpl/method/edit.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@
use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Users\Administrator\View\Method\HtmlView;
use Joomla\Utilities\ArrayHelper;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Administrator\View\Method\HtmlView $this */

$cancelURL = Route::_('index.php?option=com_users&task=methods.display&user_id=' . $this->user->id);

Expand Down
3 changes: 1 addition & 2 deletions administrator/components/com_users/tmpl/methods/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
use Joomla\CMS\Factory;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Users\Administrator\View\Methods\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Administrator\View\Methods\HtmlView $this */
?>
<div id="com-users-methods-list">
<div id="com-users-methods-reset-container" class="d-flex align-items-center border border-1 rounded-3 p-2">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
use Joomla\CMS\Factory;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Users\Administrator\View\Methods\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Administrator\View\Methods\HtmlView $this */

$headingLevel = 2;
?>
Expand Down
3 changes: 1 addition & 2 deletions administrator/components/com_users/tmpl/methods/list.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@
use Joomla\CMS\Uri\Uri;
use Joomla\Component\Users\Administrator\Helper\Mfa as MfaHelper;
use Joomla\Component\Users\Administrator\Model\MethodsModel;
use Joomla\Component\Users\Administrator\View\Methods\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Administrator\View\Methods\HtmlView $this */

HTMLHelper::_('bootstrap.tooltip', '.hasTooltip');

Expand Down
3 changes: 1 addition & 2 deletions administrator/components/com_users/tmpl/user/edit_groups.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
defined('_JEXEC') or die;

use Joomla\CMS\HTML\HTMLHelper;
use Joomla\Component\Users\Administrator\View\User\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Administrator\View\User\HtmlView $this */

echo HTMLHelper::_('access.usergroups', 'jform[groups]', $this->groups, true);
6 changes: 2 additions & 4 deletions components/com_users/tmpl/captive/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,11 @@
use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Users\Site\Model\CaptiveModel;
use Joomla\Component\Users\Site\View\Captive\HtmlView;
use Joomla\Utilities\ArrayHelper;

/**
* @var HtmlView $this View object
* @var CaptiveModel $model The model
* @var \Joomla\Component\Users\Site\View\Captive\HtmlView $this View object
* @var \Joomla\Component\Users\Site\Model\CaptiveModel $model The model
*/
$model = $this->getModel();

Expand Down
3 changes: 1 addition & 2 deletions components/com_users/tmpl/captive/select.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\CMS\Uri\Uri;
use Joomla\Component\Users\Site\View\Captive\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Site\View\Captive\HtmlView $this */

$shownMethods = [];

Expand Down
3 changes: 1 addition & 2 deletions components/com_users/tmpl/method/backupcodes.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@
use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Users\Site\View\Method\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Site\View\Method\HtmlView $this */

HTMLHelper::_('bootstrap.tooltip', '.hasTooltip');

Expand Down
3 changes: 1 addition & 2 deletions components/com_users/tmpl/method/edit.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,9 @@
use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Users\Site\View\Method\HtmlView;
use Joomla\Utilities\ArrayHelper;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Site\View\Method\HtmlView $this */

$cancelURL = Route::_('index.php?option=com_users&task=methods.display&user_id=' . $this->user->id);

Expand Down
5 changes: 2 additions & 3 deletions components/com_users/tmpl/methods/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,11 @@
use Joomla\CMS\Factory;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Users\Site\View\Methods\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Site\View\Methods\HtmlView $this */
?>
<div id="com-users-methods-list">
<?php if (!$this->get('forHMVC', false)) : ?>
<?php if (!isset($this->forHMVC) || !$this->forHMVC) : ?>
<h2 id="com-users-methods-list-head">
<?php echo Text::_('COM_USERS_MFA_LIST_PAGE_HEAD'); ?>
</h2>
Expand Down
3 changes: 1 addition & 2 deletions components/com_users/tmpl/methods/firsttime.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,8 @@
use Joomla\CMS\Factory;
use Joomla\CMS\Language\Text;
use Joomla\CMS\Router\Route;
use Joomla\Component\Users\Site\View\Methods\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Site\View\Methods\HtmlView $this */

$headingLevel = 2;
?>
Expand Down
3 changes: 1 addition & 2 deletions components/com_users/tmpl/methods/list.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,8 @@
use Joomla\CMS\Uri\Uri;
use Joomla\Component\Users\Administrator\Helper\Mfa as MfaHelper;
use Joomla\Component\Users\Site\Model\MethodsModel;
use Joomla\Component\Users\Site\View\Methods\HtmlView;

/** @var HtmlView $this */
/** @var \Joomla\Component\Users\Site\View\Methods\HtmlView $this */

/** @var MethodsModel $model */
$model = $this->getModel();
Expand Down
Loading
Loading