[6.0] Reducing PHPStan baseline #45854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heelc29
reviewed
Aug 6, 2025
administrator/components/com_joomlaupdate/tmpl/upload/default.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
|
I have tested this item ✅ successfully on 06a678d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45854. |
laoneo
approved these changes
Aug 6, 2025
|
Had the same issue with my extension, this is the only valid fix for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
PHPStan has an issue understanding the
$thisclass in our layouts with shortened class names. This PR removes the imports and instead uses the full class name when hinting at the type of$this. This allows to reduce the baseline file considerably.Testing Instructions
Since this is a change in docblocks, there isn't really anything to test. The passing of phpstan would be the indicator that this is working correctly.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed