[2.x] Replace incorrect working quoteNameStr method

[HLeithner]

Pull Request for Issue #327

[richard67]

The change of the quoteNameStr seems not to be fully b/c as there is a change in behaviour when the string to be quoted contains a dot and another difference when an array element is null.

When you call the old, unmodified, deprecated method with the following array as argument

['foo.bar','foo`bar','foo"bar','foo[bar','foo]bar',null]

you get with MySQL names quotes:

`foo.bar`.`foo`bar`.`foo"bar`.`foo[bar`.`foo]bar`

With this PR you get:

`foo`.`bar`.`foo``bar`.`foo"bar`.`foo[bar`.`foo]bar`.``

The same applies with other names quotes (PostgreSQL, MS SQL Server).

The first array element with the dot is quoted differently.

The second array element shows the fix for the issue.

The last array element shows the difference when null.

If that b/c break is a problem, I suggest following different implementation:

    function quoteNameStr($strArr)
    {
        $parts = [];

        foreach ($strArr as $part) {
            if ($part === null) {
                continue;
            }

            $parts[] = quoteNameString($part, true);
        }

        return implode('.', $parts);
    }

Mind the 2nd parameter of the quoteNameString call.

My suggested code gives following result for the example array:

`foo.bar`.`foo``bar`.`foo"bar`.`foo[bar`.`foo]bar`

The same applies when using PostgreSQL or MS SQL Server names quotes: With both ways the issue would be fixed, but with this PR the first array element with the dot is quoted differently.

You can test that here: https://onlinephp.io/c/26575

[HLeithner]

thanks richard

[richard67]

@SniperSister @ramalama Could you check this PR again? Thanks in advance.