-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support remove queues, as well as pause all / resume all #59
Conversation
This reverts commit 7ab8ab3.
I encountered some issues when trying to type Connection = Box<FaktoryConnection>;
struct Client {
connection: Connection,
opts: ClientOptions,
} ... did not work. I might be missing something though.. Otherwise the PR is ready for review. |
Would you mind splitting this PR into multiple, one for each logical change? It's a little hard to review the changes when multiple of them are bundled together in this way. |
Sure |
Only queue control actions are left in this PR. Please have a look at it once again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, no notes!
Addresses #56
This change is