Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support remove queues, as well as pause all / resume all #59

Merged
merged 131 commits into from
May 25, 2024

Conversation

rustworthy
Copy link
Collaborator

@rustworthy rustworthy commented Apr 9, 2024

Addresses #56


This change is Reviewable

@rustworthy rustworthy mentioned this pull request May 9, 2024
7 tasks
@rustworthy rustworthy marked this pull request as draft May 12, 2024 15:49
@rustworthy rustworthy changed the base branch from development to main May 12, 2024 15:56
@rustworthy
Copy link
Collaborator Author

@jonhoo

I encountered some issues when trying to make Client hold a boxed dyn Connection . Our Reconnect trait mentions Self in the return value of it's only method, making the whole thing not object safe. So introducing a Client which is
a struct with the following shape ...

type Connection = Box<FaktoryConnection>;
struct Client {
  connection: Connection,
  opts: ClientOptions,
 }

... did not work.

I might be missing something though..

Otherwise the PR is ready for review.

@rustworthy rustworthy marked this pull request as ready for review May 14, 2024 06:11
@jonhoo
Copy link
Owner

jonhoo commented May 19, 2024

Would you mind splitting this PR into multiple, one for each logical change? It's a little hard to review the changes when multiple of them are bundled together in this way.

@rustworthy
Copy link
Collaborator Author

Would you mind splitting this PR into multiple, one for each logical change? It's a little hard to review the changes when multiple of them are bundled together in this way.

Sure

@rustworthy rustworthy mentioned this pull request May 20, 2024
4 tasks
@rustworthy
Copy link
Collaborator Author

@jonhoo

Only queue control actions are left in this PR. Please have a look at it once again

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, no notes!

@jonhoo jonhoo merged commit 1252419 into main May 25, 2024
19 of 20 checks passed
@rustworthy rustworthy deleted the feat/remove-queues branch May 26, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants