-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make info command return ServerState struct #60
Comments
That seems reasonable! If we also annotate it with |
Related, see my recent Faktory PR which adds a typed structure for INFO. |
Ah, this is contribsys/faktory#474? Given we're doing a breaking change as part of #49 anyway, I think we should probably just remove |
Addressed in #59 |
Info command will now return a result with
serde_json::Value
which made a lot of sense during the period when theFaktory
library was being actively developed and so the shape of the return type could change breakingly. The last time when that interface was updated was a couple of years ago and so we may want to introduce a dedicated type for it to makeClient::info
more ergonomic:While currently - provided they know the keys - this will look like:
An example usage of
Client::info
can be found hereSince a breaking change is occurring due to switch to async, the
Client::info
can be updated to returnServerState
.The text was updated successfully, but these errors were encountered: