Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #395 notes, unmarshalling JSON in Go can reduce precision for untyped numeric elements (
any
orinterface{}
) because it defaults to using Float64 as the type. We can lose precision as there are some Int64 values which can't be precisely represented as a Float64.This PR aims to do the following:
Decoder.UseNumber()
so that Faktory will preserve numeric elements. This will be off by default in 1.x but can be enabled with a flag. This will be on by default in 2.x.client.Info()
command which returns a nastymap[string]interface{}
requiring loads of type assertions. Not ergonomic or idiomatic. Instead we provide a newclient.CurrentState()
API which returns a client.FaktoryState structure which is almost entirely typed.The test suite runs green locally with UseNumber = true or false.
Related to #395