Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated & replaced BrowserUrl__c fields with new BrowserAddress__c fields #720

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Jul 16, 2024

Fixed #696 by making a couple of changes to how the browser's address is captured when logging in lightning components

  • Updated the Apex class ComponentLogger to auto-truncate JS browser fields (including LogEntryEvent__c.BrowserUrl__c)
    • The public property ComponentLogger.ComponentLogEntry.browserUrl is now deprecated & will be deleted in a future release. It's only intended to be used internally by Nebula Logger, so this hopefully doesn't impact anyone - but mentioning it here, just in case 😉
  • Replaced the text (255) fields BrowserUrl__c on LogEntryEvent__e and LogEntry__c with new long textarea (2000) fields BrowserAddress__c
    • The existing BrowserUrl__c fields are too short to store some long URLs (such as URLs with a lot of parameters), and the existing fields can't be converted from text(255) to long text area fields, so new fields are needed
    • The existing BrowserUrl__c fields will still be populated for foreseeable future (with a truncated value), but they are now considered deprecated - any references in reports, list views, queries, etc. should be updated to use the new BrowserAddress__c fields
  • Documentation: added missing data classification metadata to several existing browser fields on LogEntryEvent__e and LogEntry__c
    • This doesn't impact any functionality, it's just for documentation purposes

…elds & replacing BrowserUrl__c fields with new BrowserAddress__c fields

Also added missing data classification metadata to several existing browser fields
@jongpie jongpie added Type: Bug Something isn't working cleanup Salesforce Feature: Reporting Anything related to reports, dashboards, and the underlying data model Logging Source: Lightning Components Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura) Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine Salesforce Feature: Platform Events Items related to how platform events are leveraged by Nebula Logger labels Jul 16, 2024
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org July 16, 2024 20:00 — with GitHub Actions Inactive
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (7cf24a6) to head (9ebcb68).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #720   +/-   ##
=======================================
  Coverage   95.51%   95.52%           
=======================================
  Files          51       51           
  Lines        5687     5693    +6     
=======================================
+ Hits         5432     5438    +6     
  Misses        255      255           
Flag Coverage Δ
Apex 95.52% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jongpie jongpie merged commit 1f7dbf8 into main Jul 16, 2024
1 check passed
@jongpie jongpie deleted the bugfix/browser-url-field-string-too-long branch July 16, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine Logging Source: Lightning Components Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura) Salesforce Feature: Platform Events Items related to how platform events are leveraged by Nebula Logger Salesforce Feature: Reporting Anything related to reports, dashboards, and the underlying data model Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lwc logging issue - String too long for Nebula__BrowserUrl__c field.
2 participants