Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated & replaced HttpRequestEndpoint__c fields with new HttpRequestEndpointAddress__c fields #773

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Sep 25, 2024

Fixed #768 by deprecating the HttpRequestEndpoint__c fields on LogEntryEvent__e and LogEntry__c, and replaced them with new HttpRequestEndpointAddress__c fields that have a much longer max length (2,000 vs 255).

  • HttpRequestEndpoint__c fields are now considered deprecated since they're not capable of storing the full value of long endpoints
    • The HttpRequestEndpoint__c fields will continue to be populated for the time being, and the value is now auto-truncated to 255 characters to fix the STRING_TOO_LONG error that was reported in LogEntryEvent__e.HttpRequestEndpoint__c too short to store endpoint #768
    • The businessStatus on the fields has been updated to DeprecateCandidate
    • The inlineHelpText on the fields has been update to Deprecated: instead use the field HttpRequestEndpointAddress__c
    • The label on the fields has been update to DEPRECATED: HTTP Request Endpoint
  • Updated LogEntryRecordPage flexipage to have both HttpRequestEndpoint__c (existing) and HttpRequestEndpointAddress__c fields
    • Both fields will be shown for now, and eventually HttpRequestEndpoint__c will be removed

Related context: this is essentially the same issue & solution used in release v4.13.15 for the now-deprecated text(255) fields BrowserUrl__c not being long enough, and they were replaced with new long textarea(2000) field BrowserAddress__c (PR #720). It's probably worth reviewing all of the text fields in the data model (especially some of the older fields) to see if it would make sense to take the same approach for any other existing fields.

…ryEvent__e and LogEntry__c, and replaced them with new HttpRequestEndpointAddress__c fields that have a much longer max length (2,000 vs 255)

Also updated LogEntryEventBuilder to auto-truncate both event fields HttpRequestEndpoint__c and HttpRequestEndpointAddress__c
@jongpie jongpie added Type: Bug Something isn't working Salesforce Feature: Reporting Anything related to reports, dashboards, and the underlying data model Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine labels Sep 25, 2024
@jongpie jongpie temporarily deployed to Advanced Scratch Org September 25, 2024 04:54 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Event Monitoring Scratch Org September 25, 2024 04:54 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Platform Cache Scratch Org September 25, 2024 05:09 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to OmniStudio Scratch Org September 25, 2024 05:09 — with GitHub Actions Inactive
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (ab92cd5) to head (70db1de).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files          74       74           
  Lines        7216     7219    +3     
  Branches      199      199           
=======================================
+ Hits         6657     6660    +3     
  Misses        531      531           
  Partials       28       28           
Flag Coverage Δ
Apex 94.24% <100.00%> (+<0.01%) ⬆️
LWC 83.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jongpie jongpie merged commit cfdae6b into main Sep 27, 2024
1 check passed
@jongpie jongpie deleted the bugfix/http-request-endpoint-field-string-too-long branch September 27, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine Salesforce Feature: Reporting Anything related to reports, dashboards, and the underlying data model Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogEntryEvent__e.HttpRequestEndpoint__c too short to store endpoint
2 participants