Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serde_with): add with_suffix! #797

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

fgardt
Copy link
Contributor

@fgardt fgardt commented Nov 1, 2024

This should properly close #381.

Apart from the used example it is pretty much identical to the existing with_prefix! code, except for the few places that actually do the suffixing / trimming.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 56.33803% with 62 lines in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (2d70b70) to head (2b4658c).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
serde_with/src/with_suffix.rs 56.33% 62 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   67.34%   66.91%   -0.43%     
==========================================
  Files          40       41       +1     
  Lines        2468     2639     +171     
==========================================
+ Hits         1662     1766     +104     
- Misses        806      873      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasbb
Copy link
Owner

jonasbb commented Nov 11, 2024

Thank you for doing the work of adding with_suffix!. Since it is mostly a copy, I don't see a problem here. I like that you added a proper new example to the documentation :)

@jonasbb jonasbb merged commit 99e30d7 into jonasbb:master Nov 11, 2024
24 checks passed
@fgardt
Copy link
Contributor Author

fgardt commented Dec 6, 2024

any ETA for a new release that would contain this? @jonasbb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add with_suffix macro?
2 participants