Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add with_suffix macro? #381

Closed
tobiasvl opened this issue Oct 22, 2021 · 2 comments · Fixed by #797
Closed

Add with_suffix macro? #381

tobiasvl opened this issue Oct 22, 2021 · 2 comments · Fixed by #797
Labels
enhancement New feature or request

Comments

@tobiasvl
Copy link

Perhaps not such a common use case as stripping prefixes, but it would be nice if there was a symmetrical with_suffix macro that could strip suffixes.
@jonasbb
Copy link
Owner

jonasbb commented Oct 22, 2021

Hi, thanks for the interest. I am open to accepting a PR to add this macro. I have not seen much demand for such a macro so far.

The implementation can probably mostly be taken from the existing with_prefix macro, the main differences being the parts where the prefix is added/stripped.

@jonasbb jonasbb added the enhancement New feature or request label Nov 2, 2021
@jonasbb
Copy link
Owner

jonasbb commented May 3, 2023

If someone needs this, feel welcome to submit a PR. But I would rather not keep the issue open indefinitely.

@jonasbb jonasbb closed this as completed May 3, 2023
@dtolnay dtolnay mentioned this issue May 12, 2024
Closed
@fgardt fgardt mentioned this issue Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(serde_with): add with_suffix! fgardt/serde_with
2 participants
@tobiasvl @jonasbb