chore(sync): merge upstream pingdotgg/t3code 04ad17425a (114 commits) into fork main

.coderabbit.config.ts

@@ -1,14 +1,22 @@
-import { defineConfig } from "@coderabbitai/config";
+import { defineConfig, type CodeRabbitContext } from "@coderabbitai/config";
 
-export default defineConfig({
+// Org members and collaborators merge their own pull requests. On anyone else's, CodeRabbit
+// requests changes until its comments are resolved, then approves.
+const UNGATED_AUTHORS = new Set(["OWNER", "MEMBER", "COLLABORATOR"]);
+const isGated = ({ pr }: CodeRabbitContext) => !UNGATED_AUTHORS.has(pr?.authorAssociation ?? "");
+
+export default defineConfig((ctx) => ({
   reviews: {
     high_level_summary: false,
     review_status: false,
+    request_changes_workflow: isGated(ctx),
+    allow_author_approval: !isGated(ctx),
     auto_review: {
       enabled: true,
     },
     pre_merge_checks: {
       docstrings: { mode: "off" },
+      override_requested_reviewers_only: isGated(ctx),
     },
     path_filters: [
       // Vendored read-only reference checkouts of upstream Effect and Alchemy
@@ -34,4 +42,4 @@ export default defineConfig({
       ],
     },
   },
-});
+}));

.github/workflows/ci.yml

@@ -272,6 +272,9 @@ jobs:
       # No Electron setup here: `t3` (apps/server) has no Electron dependency
       # and none of its tests touch the runtime. Only the non-server `test`
       # job, which covers @t3tools/desktop, needs the download.
+      - name: Install Chromium for server browser integration tests
+        run: node apps/server/node_modules/playwright-core/cli.js install --with-deps --only-shell chromium
+
       - name: Test
         env:
           T3CODE_TRANSFER_BUDGET_REPORT_PATH: ${{ runner.temp }}/t3code-transfer-budget.md

.github/workflows/release.yml

@@ -337,6 +337,9 @@ jobs:
       # No Electron setup here: `t3` (apps/server) has no Electron dependency
       # and none of its tests touch the runtime. Only the non-server `test`
       # job, which covers @t3tools/desktop, needs the download.
+      - name: Install Chromium for server browser integration tests
+        run: node apps/server/node_modules/playwright-core/cli.js install --with-deps --only-shell chromium
+
       - name: Test
         run: vp run --filter t3 test --shard ${{ matrix.shard }}/${{ strategy.job-total }}
 

.t3team-additive-guard.json

@@ -90,6 +90,7 @@
     "apps/server/src/mcp/toolkits/thread/handlers.ts",
     "apps/server/src/mcp/toolkits/worktree/handlers.ts",
     "apps/server/src/mcp/toolkits/worktree/tools.ts",
+    "apps/server/src/observability/RpcInstrumentation.ts",
     "apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts",
     "apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts",
     "apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts",
@@ -184,6 +185,7 @@
     "apps/server/src/provider/opencodeRuntime.ts",
     "apps/server/src/provider/providerStatusCache.test.ts",
     "apps/server/src/provider/providerStatusCache.ts",
+    "apps/server/src/pullRequest/GitHubPullRequestApi.ts",
     "apps/server/src/pullRequest/GitHubPullRequestCli.test.ts",
     "apps/server/src/pullRequest/GitHubPullRequestCli.ts",
     "apps/server/src/pullRequest/GitHubPullRequestProvider.ts",
@@ -288,6 +290,7 @@
     "apps/web/src/components/chat/BackgroundJobsIndicator.tsx",
     "apps/web/src/components/chat/ChatComposer.tsx",
     "apps/web/src/components/chat/ComposerCommandMenu.tsx",
+    "apps/web/src/components/chat/ComposerPendingUserInputPanel.permissions.test.tsx",
     "apps/web/src/components/chat/ComposerPendingUserInputPanel.test.tsx",
     "apps/web/src/components/chat/ComposerPendingUserInputPanel.tsx",
     "apps/web/src/components/chat/ComposerPrimaryActions.tsx",
@@ -318,6 +321,8 @@
     "apps/web/src/components/composerFooterLayout.ts",
     "apps/web/src/components/contextPresentationRegistry.ts",
     "apps/web/src/components/files/FileBrowserPanel.tsx",
+    "apps/web/src/components/onboarding/WelcomeWizard.import.test.tsx",
+    "apps/web/src/components/onboarding/WelcomeWizard.terminal.test.tsx",
     "apps/web/src/components/onboarding/WelcomeWizard.test.tsx",
     "apps/web/src/components/onboarding/WelcomeWizard.tsx",
     "apps/web/src/components/preview/PreviewPanel.tsx",
@@ -377,6 +382,7 @@
     "apps/web/src/session-logic.test.ts",
     "apps/web/src/session-logic.ts",
     "apps/web/src/state/query.ts",
+    "apps/web/src/state/terminalSessionAvailability.test.ts",
     "apps/web/src/state/terminalSessions.ts",
     "apps/web/src/state/threads.ts",
     "apps/web/src/t3team/components/t3team-LocalWorkspaceSidebarRow.tsx",
@@ -669,7 +675,7 @@
     "apps/web/src/t3team/packs/t3team-kit-fixture-pack/pack.json"
   ],
   "baseRef": "upstream/main",
-  "forkBaselineRef": "t3team/fork-baseline-20261006",
+  "forkBaselineRef": "t3team/fork-baseline-20261008",
   "guardFileRule": "DO NOT EDIT THIS FILE MANUALLY. Update allowlists via controlled migration changes only.",
   "locFailThreshold": 200,
   "locWarnThreshold": 150,

AGENTS.md

@@ -315,6 +315,7 @@ Architecture and its constraints: `docs/internals/overview.md`. Glossary: `docs/
 ## Taste
 
 - Complexity belongs at the adapter boundary. Orchestration stays pure, UI stays dumb.
+- Client mutations use `createEnvironmentRpcCommand`. Add protected methods to `CLIENT_GUARDED_RPC_SCOPES` in contracts and use the command's `permissionAtom` for UI availability. Grants are checked at execution against the destination environment; the server remains authoritative. Keep raw RPC clients inside `rpc/`, and extend the permission behavior tests when adding a protected method.
 - Server features are services; transports stay thin. A `ws.ts` RPC handler, HTTP route, or MCP tool decodes input, calls one service method, and maps errors. See [Effect services](docs/internals/effect-services.md).
 - `apps/web/src/components/ui` exports own their look. Pick a `variant` or `size`; do not restyle one with `className`. If none fits and the look is a generic concept, add a variant to the component; a look that belongs to one feature stays in that feature's own component, not in `components/ui`. Layout classes (width, flex, margin, position) belong on the parent. `shadcn/no-restyle` fails lint on violations. See [Web UI](docs/internals/web-ui.md).
 - Inferred types over annotations. `any` is the enemy.

README.md

@@ -125,6 +125,7 @@ Full docs live in [docs/](./docs). There's no docs site yet.
 - [Project settings](./docs/user/project-settings.md)
 - [Appearance preferences](./docs/user/appearance.md)
 - [Remote access from a phone or another machine](./docs/user/remote-access.md)
+- [Connect Claude Code, Codex, ChatGPT and other agents over MCP](./docs/user/outside-agents.md)
 - [Keeping app and server in sync](./docs/user/updating.md)
 - [Source control integrations](./docs/user/source-control.md)
 - Multiple accounts: [Codex](./docs/user/providers-codex.md) · [Claude](./docs/user/providers-claude.md)

apps/desktop/resources/linux/com.t3tools.t3code.metainfo.xml

@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<component type="desktop-application">
+  <id>com.t3tools.t3code</id>
+  <metadata_license>CC0-1.0</metadata_license>
+  <project_license>MIT</project_license>
+  <name>T3 Code</name>
+  <summary>Desktop GUI for coding agents</summary>
+  <developer id="com.t3tools">
+    <name>T3 Tools Inc.</name>
+  </developer>
+  <description>
+    <p>
+      T3 Code is an open-source desktop app for coding agents. Work with your
+      existing agent subscriptions, review code changes, and run commands in
+      your projects.
+    </p>
+    <p>
+      Connect from desktop, web, or mobile to continue working remotely.
+    </p>
+  </description>
+  <launchable type="desktop-id">t3code.desktop</launchable>
+  <icon type="stock">t3code</icon>
+  <provides>
+    <binary>t3code</binary>
+  </provides>
+  <categories>
+    <category>Development</category>
+  </categories>
+  <url type="homepage">https://t3.codes</url>
+  <url type="bugtracker">https://github.com/pingdotgg/t3code/issues</url>
+  <url type="vcs-browser">https://github.com/pingdotgg/t3code</url>
+</component>

apps/desktop/src/app/DesktopCliCommand.test.ts

@@ -0,0 +1,243 @@
+import * as NodeServices from "@effect/platform-node/NodeServices";
+import { expect, it } from "@effect/vitest";
+import * as Effect from "effect/Effect";
+import * as FileSystem from "effect/FileSystem";
+import * as Option from "effect/Option";
+import * as Path from "effect/Path";
+import * as Sink from "effect/Sink";
+import * as Stream from "effect/Stream";
+import * as ChildProcessSpawner from "effect/process/ChildProcessSpawner";
+
+import * as DesktopCliCommand from "./DesktopCliCommand.ts";
+import * as DesktopCliShim from "./DesktopCliShim.ts";
+import * as DesktopEnvironment from "./DesktopEnvironment.ts";
+
+const environmentFor = (
+  path: Path.Path,
+  input: { home: string; baseDir: string; platform?: NodeJS.Platform; isPackaged?: boolean },
+) =>
+  DesktopEnvironment.DesktopEnvironment.of({
+    path,
+    platform: input.platform ?? "linux",
+    isPackaged: input.isPackaged ?? true,
+    homeDirectory: input.home,
+    baseDir: input.baseDir,
+    stateDir: path.join(input.baseDir, "userdata"),
+    serverRoot: "/opt/T3 Code/resources/app.asar",
+    appImagePath: Option.none(),
+  } as unknown as DesktopEnvironment.DesktopEnvironment["Service"]);
+
+/** The service for a packaged app; the launcher is written on Install. */
+const commandIn = (
+  input: { home: string; baseDir?: string; platform?: NodeJS.Platform; isPackaged?: boolean },
+  spawner?: ChildProcessSpawner.ChildProcessSpawner["Service"],
+) =>
+  Effect.gen(function* () {
+    const path = yield* Path.Path;
+    const fs = yield* FileSystem.FileSystem;
+    const baseDir = input.baseDir ?? path.join(input.home, ".t3");
+    yield* fs.makeDirectory(path.join(baseDir, "userdata"), { recursive: true });
+    const make = DesktopCliCommand.make.pipe(
+      Effect.provideService(
+        DesktopEnvironment.DesktopEnvironment,
+        environmentFor(path, { ...input, baseDir }),
+      ),
+    );
+    return yield* spawner
+      ? make.pipe(Effect.provideService(ChildProcessSpawner.ChildProcessSpawner, spawner))
+      : make;
+  });
+
+/** A PowerShell that keeps the user's PATH in memory and can be told to fail reads. */
+const fakePowerShell = (initial: string) => {
+  const registry = { path: initial, failReads: false, writes: 0 };
+  const spawner = ChildProcessSpawner.make((command) =>
+    Effect.sync(() => {
+      const { options } = command as unknown as {
+        readonly options: { readonly env?: Record<string, string> };
+      };
+      const env = options.env ?? {};
+      let exitCode = 0;
+      let stdout = "";
+      if (env.T3_SET === "1") {
+        registry.path = env.T3_PATH ?? "";
+        registry.writes += 1;
+      } else if (registry.failReads) {
+        exitCode = 1;
+      } else {
+        stdout = Buffer.from(registry.path, "utf8").toString("base64");
+      }
+      return ChildProcessSpawner.makeHandle({
+        pid: ChildProcessSpawner.ProcessId(1),
+        exitCode: Effect.succeed(ChildProcessSpawner.ExitCode(exitCode)),
+        isRunning: Effect.succeed(false),
+        kill: () => Effect.void,
+        unref: Effect.succeed(Effect.void),
+        stdin: Sink.drain,
+        stdout: Stream.make(new TextEncoder().encode(stdout)),
+        stderr: Stream.empty,
+        all: Stream.empty,
+        getInputFd: () => Sink.drain,
+        getOutputFd: () => Stream.empty,
+      });
+    }),
+  );
+  return { registry, spawner };
+};
+
+it.layer(NodeServices.layer)("DesktopCliCommand", (it) => {
+  it.effect("links the launcher onto PATH and removes only that link", () =>
+    Effect.gen(function* () {
+      const fs = yield* FileSystem.FileSystem;
+      const path = yield* Path.Path;
+      const home = yield* fs.makeTempDirectoryScoped();
+      const command = yield* commandIn({ home });
+      const link = path.join(home, ".local", "bin", "t3");
+
+      expect(yield* command.state).toEqual({ supported: true, installedPath: null, onPath: false });
+      // Install writes the launcher itself, even when no local backend ever did.
+      const installed = yield* command.install;
+      expect(installed.installedPath).toBe(link);
+      expect(yield* fs.readLink(link)).toBe(path.join(home, ".t3", "bin", "t3"));
+      expect((yield* command.install).installedPath).toBe(link);
+
+      expect((yield* command.uninstall).installedPath).toBeNull();
+      expect(yield* fs.exists(link)).toBe(false);
+      // The launcher itself stays for setup commands.
+      expect(yield* fs.exists(path.join(home, ".t3", "bin", "t3"))).toBe(true);
+    }).pipe(Effect.scoped),
+  );
+
+  it.effect("never replaces or removes a t3 it did not create", () =>
+    Effect.gen(function* () {
+      const fs = yield* FileSystem.FileSystem;
+      const path = yield* Path.Path;
+      const home = yield* fs.makeTempDirectoryScoped();
+      const command = yield* commandIn({ home });
+      const theirs = path.join(home, ".local", "bin", "t3");
+      yield* fs.makeDirectory(path.dirname(theirs), { recursive: true });
+      yield* fs.writeFileString(theirs, "npm's t3\n");
+      // Even a broken link in the next folder is someone else's.
+      yield* fs.makeDirectory(path.join(home, "bin"), { recursive: true });
+      yield* fs.symlink(path.join(home, "gone"), path.join(home, "bin", "t3"));
+
+      const error = yield* Effect.flip(command.install);
+      expect(error.message).toContain("Another t3 command is already installed");
+      yield* command.uninstall;
+      expect(yield* fs.readFileString(theirs)).toBe("npm's t3\n");
+      expect(yield* fs.readLink(path.join(home, "bin", "t3"))).toBe(path.join(home, "gone"));
+    }).pipe(Effect.scoped),
+  );
+
+  it.effect("finds and removes a link left by a previous T3 home", () =>
+    Effect.gen(function* () {
+      const fs = yield* FileSystem.FileSystem;
+      const path = yield* Path.Path;
+      const home = yield* fs.makeTempDirectoryScoped();
+      const before = yield* commandIn({ home, baseDir: path.join(home, "old-t3") });
+      const link = (yield* before.install).installedPath;
+
+      const after = yield* commandIn({ home, baseDir: path.join(home, "new-t3") });
+      expect((yield* after.state).installedPath).toBe(link);
+      // Installing again points the link at this home's launcher.
+      expect((yield* after.install).installedPath).toBe(link);
+      expect(yield* fs.readLink(link!)).toBe(path.join(home, "new-t3", "bin", "t3"));
+      yield* after.uninstall;
+      expect(yield* fs.exists(path.join(home, ".local", "bin", "t3"))).toBe(false);
+      expect(yield* fs.exists(path.join(home, "bin", "t3"))).toBe(false);
+    }).pipe(Effect.scoped),
+  );
+
+  it.effect("does not read a large binary another t3 links to", () =>
+    Effect.gen(function* () {
+      const fs = yield* FileSystem.FileSystem;
+      const path = yield* Path.Path;
+      const home = yield* fs.makeTempDirectoryScoped();
+      // A big executable that happens to contain the marker text is still not ours.
+      const binary = path.join(home, "native-t3");
+      yield* fs.writeFileString(binary, `${"\0".repeat(64 * 1024)}${DesktopCliShim.MARKER}`);
+      yield* fs.makeDirectory(path.join(home, ".local", "bin"), { recursive: true });
+      yield* fs.symlink(binary, path.join(home, ".local", "bin", "t3"));
+      const command = yield* commandIn({ home });
+      expect((yield* command.state).installedPath).toBeNull();
+      yield* command.uninstall;
+      expect(yield* fs.readLink(path.join(home, ".local", "bin", "t3"))).toBe(binary);
+    }).pipe(Effect.scoped),
+  );
+
+  it.effect("reports when another t3 earlier on PATH would run instead", () =>
+    Effect.gen(function* () {
+      const fs = yield* FileSystem.FileSystem;
+      const path = yield* Path.Path;
+      const home = yield* fs.makeTempDirectoryScoped();
+      const shadow = path.join(home, "shadow");
+      yield* fs.makeDirectory(shadow);
+      yield* fs.writeFileString(path.join(shadow, "t3"), "#!/bin/sh\n", { mode: 0o755 });
+      const previous = process.env.PATH;
+      process.env.PATH = [shadow, path.join(home, ".local", "bin")].join(":");
+      yield* Effect.addFinalizer(() => Effect.sync(() => (process.env.PATH = previous)));
+
+      const command = yield* commandIn({ home });
+      const installed = yield* command.install;
+      expect(installed.installedPath).toBe(path.join(home, ".local", "bin", "t3"));
+      expect(installed.onPath).toBe(false);
+      yield* fs.remove(path.join(shadow, "t3"));
+      expect((yield* command.state).onPath).toBe(true);
+    }).pipe(Effect.scoped),
+  );
+
+  it.effect("leaves the Windows PATH alone when it cannot be read", () =>
+    Effect.gen(function* () {
+      const fs = yield* FileSystem.FileSystem;
+      const home = yield* fs.makeTempDirectoryScoped();
+      const userPath = "C:\\Users\\Me\\npm;%USERPROFILE%\\tools";
+      const { registry, spawner } = fakePowerShell(userPath);
+      const command = yield* commandIn({ home, platform: "win32" }, spawner);
+
+      registry.failReads = true;
+      const error = yield* Effect.flip(command.install);
+      expect(error.message).toContain("left unchanged");
+      expect(registry).toMatchObject({ path: userPath, writes: 0 });
+
+      registry.failReads = false;
+      const launcherDir = DesktopCliShim.launcherPath(
+        environmentFor(yield* Path.Path, { home, baseDir: `${home}/.t3`, platform: "win32" }),
+      ).replace(/[\\/]t3\.cmd$/, "");
+      yield* command.install;
+      expect(registry.path).toBe(`${userPath};${launcherDir}`);
+      yield* command.uninstall;
+      expect(registry.path).toBe(userPath);
+    }).pipe(Effect.scoped),
+  );
+
+  it.effect("does not claim or remove a Windows PATH entry the user added", () =>
+    Effect.gen(function* () {
+      const fs = yield* FileSystem.FileSystem;
+      const path = yield* Path.Path;
+      const home = yield* fs.makeTempDirectoryScoped();
+      const launcherDir = path.dirname(
+        DesktopCliShim.launcherPath(
+          environmentFor(path, { home, baseDir: path.join(home, ".t3"), platform: "win32" }),
+        ),
+      );
+      const userPath = `C:\\Tools;${launcherDir}`;
+      const { registry, spawner } = fakePowerShell(userPath);
+      const command = yield* commandIn({ home, platform: "win32" }, spawner);
+
+      expect((yield* command.state).installedPath).toBeNull();
+      yield* command.uninstall;
+      expect(registry.path).toBe(userPath);
+    }).pipe(Effect.scoped),
+  );
+
+  it.effect("offers nothing for a development build", () =>
+    Effect.gen(function* () {
+      const fs = yield* FileSystem.FileSystem;
+      const command = yield* commandIn({
+        home: yield* fs.makeTempDirectoryScoped(),
+        isPackaged: false,
+      });
+      expect((yield* command.state).supported).toBe(false);
+    }).pipe(Effect.scoped),
+  );
+});